Add origin_address to authentication_success#36409
Merged
albertzaharovits merged 2 commits intoelastic:6.xfrom Dec 10, 2018
Merged
Add origin_address to authentication_success#36409albertzaharovits merged 2 commits intoelastic:6.xfrom
albertzaharovits merged 2 commits intoelastic:6.xfrom
Conversation
albertzaharovits
added
>non-issue
:Security/Authorization
Collaborator
|
Pinging @elastic/es-security |
jaymode
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
origin_addressfield should be present on all events (there is no reason not to), but it is missing inauthentication_successevents for the deprecated logfile audit logging.It is easier to fix the code than the docs:
https://www.elastic.co/guide/en/elastic-stack-overview/6.5/audit-event-types.html#audit-event-attributes
(It was easier to write the docs in #35510 the way they are, than to accommodate for this omission)