Remove deprecated useDisMax from MultiMatchQuery#36488
Remove deprecated useDisMax from MultiMatchQuery#36488cbuescher merged 3 commits intoelastic:masterfrom
useDisMax from MultiMatchQuery#36488Conversation
The getters and setters for useDisMax() have been deprecated since at least 6.0, also there hasn't been any reference to the query parameter in the documentation. Removing it from the builder and tests and replacing it with `tieBreaker(1.0f)` where necessary.
cbuescher
added
>non-issue
:Search/Search
|
Pinging @elastic/es-search |
jtibshirani
left a comment
jtibshirani
left a comment
There was a problem hiding this comment.
Looks good to me. To be really safe we could deprecate the use_dis_max REST parameter in 6.6? The parameter may still pop up in some places -- for example, it looks like it's being used in JdbcCsvSpecIT.
| out.writeOptionalString(fuzzyRewrite); | ||
| out.writeOptionalBoolean(useDisMax); | ||
| if (out.getVersion().before(Version.V_7_0_0)) { | ||
| out.writeOptionalBoolean(null); // |
There was a problem hiding this comment.
A comment here would be nice (or we could remove the extra marker //)?
There was a problem hiding this comment.
Sorry, leftover. Will remove.
I misses this usage in some sql qa tests. Adding deprecation warnings for the rest usages in 6.x are a good idea but I'd say we can still remove it in 7.0 since at least for MultiMatch this parameter hasn't been documented at last since 5.6 (there was some docs for use in Query string query, but there also has been a note in |
|
@elasticmachien test this please |
* elastic/master: Remove deprecated `useDisMax` from MultiMatchQuery (elastic#36488) HLRC: Add get users action (elastic#36332) fix MultiValuesSourceFieldConfig toXContent (elastic#36525) Add ILM-specific security privileges (elastic#36493) Remove usages of `MockTcpTransport` from zen tests (elastic#36579)
The rest parameter is already deprecated at least since 6.0, we should also add a warnign when the parameter gets used via the query DSL. Relates to elastic#36488
The rest parameter is already deprecated at least since 6.0, we should also add a warnign when the parameter gets used via the query DSL. Relates to #36488
4 participants
The getters and setters for useDisMax() have been deprecated since at least 6.0,
also there hasn't been any reference to the query parameter in the
documentation. Removing it from the builder and tests and replacing it with
tieBreaker(1.0f)where necessary.