Introduce an include_type_name constant#37155
Conversation
I started referring to this parameter name from various places in elastic#37149 so I think it's a good idea to simplify things by referring to a common constant.
jtibshirani
left a comment
jtibshirani
left a comment
There was a problem hiding this comment.
Thanks @cbuescher, it will be nice to avoid hardcoding this in more places. I also can't think of a better place to put the constant.
|
One other thought: it would be good to backport this to 6.x as well, maybe after #37147 merges. |
cbuescher
added
>non-issue
v7.0.0
:Search Foundations/Mapping
|
Pinging @elastic/es-search |
@jtibshirani When I just looked at backporting the constant, I saw that neither of the three APIs changed here (create index, get mapping, put mapping) already use the "include_type_name" parameter on 6.x. Is the "include_type_name" backport for these APIs pending or don't we plan on supporting it? I was of the impression it is the former but wanted to confirm. Will not backport for now until the parameter is supported anywhere in 6.x. |
|
Your understanding is correct -- the backport was opened in #37147 and is still pending. |
4 participants
I started referring to this parameter name from various places in #37149 so I
thought it's a good idea to simplify things by referring to a common constant.
If you think there are better places to put it than BaseRestHandler please suggest
alternatives. Then again, it will be there only temporarily.