Allow field types to optimize phrase prefix queries#37436
Merged
jimczi merged 9 commits intoelastic:masterfrom Jan 17, 2019
Merged
Allow field types to optimize phrase prefix queries#37436jimczi merged 9 commits intoelastic:masterfrom
jimczi merged 9 commits intoelastic:masterfrom
Conversation
This change adds a way to customize how phrase prefix queries should be created on field types. The match phrase prefix query is exposed in field types in order to allow optimizations based on the options set on the field. For instance the text field uses the configured prefix field (if available) to build a span near that mixes the original field and the prefix field on the last position. This change also contains a small refactoring of the match/multi_match query that simplifies the interactions between the builders. Closes elastic#31921
jimczi
added
>enhancement
:Search/Search
Collaborator
|
Pinging @elastic/es-search |
romseygeek
reviewed
Jan 15, 2019
Contributor
romseygeek
left a comment
romseygeek
left a comment
There was a problem hiding this comment.
Nice! I have a couple of minor questions, and one major one around the difference in semantics between phrase slop and span slop.
server/src/main/java/org/elasticsearch/common/lucene/search/MultiPhrasePrefixQuery.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/mapper/TextFieldMapper.java
Show resolved
Hide resolved
| .build(); | ||
| assertThat(q6, equalTo(expected)); | ||
|
|
||
| Query q7 = matchQuery.parse(MatchQuery.Type.PHRASE_PREFIX, "field", "motor d"); |
Contributor
There was a problem hiding this comment.
Might be interesting in future to use the wildcard expansion from #36703 here as well?
Contributor
Author
There was a problem hiding this comment.
Yes, good idea. I can do that in a follow up.
server/src/test/java/org/elasticsearch/index/mapper/TextFieldMapperTests.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/index/query/MatchQueryBuilderTests.java
Show resolved
Hide resolved
Contributor
Author
|
run the gradle build tests 1 |
Contributor
Author
|
run the gradle build tests 2 |
Contributor
Author
|
@elasticmachine run gradle build tests 1 |
Contributor
Author
|
@elasticmachine run gradle build tests 1 |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Jan 17, 2019
…-response-header-performance * elastic/master: Remove Redundant RestoreRequest Class (elastic#37535) Create specific exception for when snapshots are in progress (elastic#37550) Mute UnicastZenPingTests#testSimplePings [DOCS] Adds size limitation to the get datafeeds APIs (elastic#37578) Fix assertion at end of forceRefreshes (elastic#37559) Propagate Errors in executors to uncaught exception handler (elastic#36137) [DOCS] Adds limitation to the get jobs API (elastic#37549) Add set_priority action to ILM (elastic#37397) Make recovery source send operations non-blocking (elastic#37503) Allow field types to optimize phrase prefix queries (elastic#37436) Added fatal_exception field for ccr stats in monitoring mapping. (elastic#37563) Fix testRelocateWhileContinuouslyIndexingAndWaitingForRefresh (elastic#37560) Moved ccr integration to the package with other ccr integration tests. Mute TransportClientNodesServiceTests#testListenerFailures Decreased time out in test Fix erroneous docstrings for abstract bulk by scroll request (elastic#37517) SQL: Rename SQL type DATE to DATETIME (elastic#37395) Remove the AbstracLifecycleComponent constructor with Settings (elastic#37523)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a way to customize how phrase prefix queries should be created
on field types. The match phrase prefix query is exposed in field types in order
to allow optimizations based on the options set on the field.
For instance the text field uses the configured prefix field (if available) to
build a span near that mixes the original field and the prefix field on the last
position.
This change also contains a small refactoring of the match/multi_match query that
simplifies the interactions between the builders.
Closes #31921