Add run under primary permit method#37440
Merged
jasontedor merged 2 commits intoelastic:masterfrom Jan 15, 2019
Merged
Conversation
This commit adds a simple method for executing a runnable against a shard under a primary permit. Today there is only a single caller for this method, but this there are two upcoming use-cases for which having this method will help keep the code simpler.
jasontedor
added
>enhancement
v7.0.0
:Distributed/Distributed
Collaborator
|
Pinging @elastic/es-distributed |
Member
Author
|
@elasticmachine run gradle build tests 1 |
jasontedor
commented
Jan 14, 2019
| e -> { | ||
| if (e instanceof AlreadyClosedException == false | ||
| && e instanceof IndexShardClosedException == false) { | ||
| logger.warn( |
Member
Author
There was a problem hiding this comment.
I did change this in this PR to from info to warn. I think warn is more appropriate.
jasontedor
added a commit
that referenced
this pull request
Jan 15, 2019
This commit adds a simple method for executing a runnable against a shard under a primary permit. Today there is only a single caller for this method, but this there are two upcoming use-cases for which having this method will help keep the code simpler.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Jan 15, 2019
* master: Add run under primary permit method (elastic#37440)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a simple method for executing a runnable against a shard under a primary permit. Today there is only a single caller for this method, but this there are two upcoming use-cases for which having this method will help keep the code simpler.
Relates #37398