Refactored GeoHashGrid unit tests#37832
Merged
nyurik merged 3 commits intoelastic:masterfrom Jan 25, 2019
Merged
Conversation
nyurik
force-pushed
the
geohashgrid_tests-v2
branch
from
3a719c8 to
d9df172
Compare
talevy
reviewed
Jan 24, 2019
Contributor
talevy
left a comment
talevy
left a comment
There was a problem hiding this comment.
overall looks good! left a few comments
...est/java/org/elasticsearch/search/aggregations/bucket/geogrid/GeoGridAggregatorTestBase.java
Outdated
Show resolved
Hide resolved
...est/java/org/elasticsearch/search/aggregations/bucket/geogrid/GeoGridAggregatorTestBase.java
Outdated
Show resolved
Hide resolved
...est/java/org/elasticsearch/search/aggregations/bucket/geogrid/GeoGridAggregatorTestBase.java
Outdated
Show resolved
Hide resolved
...est/java/org/elasticsearch/search/aggregations/bucket/geogrid/GeoGridAggregatorTestBase.java
Outdated
Show resolved
Hide resolved
...est/java/org/elasticsearch/search/aggregations/bucket/geogrid/GeoGridAggregatorTestBase.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/search/aggregations/bucket/geogrid/GeoGridTestBase.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/search/aggregations/bucket/geogrid/GeoGridTestBase.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/search/aggregations/bucket/geogrid/GeoGridTestBase.java
Outdated
Show resolved
Hide resolved
imotov
suggested changes
Jan 24, 2019
...est/java/org/elasticsearch/search/aggregations/bucket/geogrid/GeoGridAggregatorTestBase.java
Outdated
Show resolved
Hide resolved
...est/java/org/elasticsearch/search/aggregations/bucket/geogrid/GeoGridAggregatorTestBase.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/search/aggregations/bucket/geogrid/GeoGridTestBase.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/search/aggregations/bucket/geogrid/GeoGridTestBase.java
Outdated
Show resolved
Hide resolved
...est/java/org/elasticsearch/search/aggregations/bucket/geogrid/GeoGridAggregatorTestBase.java
Outdated
Show resolved
Hide resolved
nyurik
force-pushed
the
geohashgrid_tests-v2
branch
2 times, most recently
from
5ecbd07 to
48e25e8
Compare
nyurik
added
:Analytics/Geo
Collaborator
|
Pinging @elastic/es-analytics-geo |
This change allows other grid aggregations to reuse the same tests. The change mostly just moves code to the base classes, trying to keep changes to a bare minimum.
nyurik
force-pushed
the
geohashgrid_tests-v2
branch
from
da7c7af to
8848778
Compare
imotov
approved these changes
Jan 25, 2019
talevy
approved these changes
Jan 25, 2019
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Jan 25, 2019
* elastic/master: (68 commits) Fix potential IllegalCapacityException in LLRC when selecting nodes (elastic#37821) Mute CcrRepositoryIT#testFollowerMappingIsUpdated Fix S3 Repository ITs When Docker is not Available (elastic#37878) Pass distribution type through to docs tests (elastic#37885) Mute SharedClusterSnapshotRestoreIT#testSnapshotCanceledOnRemovedShard SQL: Fix casting from date to numeric type to use millis (elastic#37869) Migrate o.e.i.r.RecoveryState to Writeable (elastic#37380) ML: removing unnecessary upgrade code (elastic#37879) Relax cluster metadata version check (elastic#37834) Mute TransformIntegrationTests#testSearchTransform Refactored GeoHashGrid unit tests (elastic#37832) Fixes for a few randomized agg tests that fail hasValue() checks Geo: replace intermediate geo objects with libs/geo (elastic#37721) Remove NOREPLACE for /etc/elasticsearch in rpm and deb (elastic#37839) Remove "reinstall" packaging tests (elastic#37851) Add unit tests for ShardStateAction's ShardStartedClusterStateTaskExecutor (elastic#37756) Exit batch files explictly using ERRORLEVEL (elastic#29583) TransportUnfollowAction should increase settings version (elastic#37859) AsyncTwoPhaseIndexerTests race condition fixed (elastic#37830) Do not allow negative variances (elastic#37384) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows other grid aggregations to reuse the same tests.
The change mostly just moves code to the base classes, trying to
keep changes to a bare minimum. A follow up refactoring might
want to rename some variables to remove explicit "geohash" from the base.