Rename static Zen1 settings#38333
Merged
DaveCTurner merged 7 commits intoelastic:masterfrom Feb 5, 2019
Merged
Conversation
Renames the following settings to remove the mention of `zen` in their names: - `discovery.zen.hosts_provider` -> `discovery.seed_providers` - `discovery.zen.ping.unicast.concurrent_connects` -> `discovery.seed_resolver.max_concurrent_resolvers` - `discovery.zen.ping.unicast.hosts.resolve_timeout` -> `discovery.seed_resolver.timeout` - `discovery.zen.ping.unicast.hosts` -> `discovery.seed_addresses`
DaveCTurner
added
>non-issue
WIP
v7.0.0
:Distributed/Cluster Coordination
Collaborator
|
Pinging @elastic/es-distributed |
61 tasks
Member
Author
|
@elasticmachine run elasticsearch-ci/1 |
ywelsch
approved these changes
Feb 4, 2019
| + | ||
| Defaults to `["127.0.0.1", "[::1]"]`. | ||
| existent IP addresses will throw exceptions and cause another DNS lookup on the | ||
| next round of pinging (subject to JVM DNS caching). + Defaults to |
| } | ||
| List<String> hostsProviderNames = DISCOVERY_HOSTS_PROVIDER_SETTING.get(settings); | ||
|
|
||
| List<String> hostsProviderNames = getSeedProviderNames(settings); |
Contributor
There was a problem hiding this comment.
rename this variable as well?
|
|
||
| import static org.elasticsearch.discovery.zen.UnicastZenPing.DISCOVERY_ZEN_PING_UNICAST_CONCURRENT_CONNECTS_SETTING; | ||
|
|
||
| public class UnicastConfiguredHostsResolver extends AbstractLifecycleComponent implements ConfiguredHostsResolver { |
Contributor
There was a problem hiding this comment.
we can rename these classes in a follow-up
| Setting.positiveTimeSetting("discovery.zen.ping.unicast.hosts.resolve_timeout", TimeValue.timeValueSeconds(5), | ||
| Property.NodeScope, Property.Deprecated); | ||
|
|
||
| public static final Setting<Integer> DISCOVERY_SEED_RESOLVER_MAX_CONCURRENT_RESOLVERS_SETTING = |
Contributor
There was a problem hiding this comment.
a bit ugly that we have to define this new setting in this class that's going away. We can clean that up later though when removing Zen1
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Feb 5, 2019
* master: Mute failing API key integration test (elastic#38409) Change the milliseconds precision to 3 digits for intervals. (elastic#38297) SecuritySettingsSource license.self_generated: trial (elastic#38233) Rename no-master-block setting (elastic#38350) Rename static Zen1 settings (elastic#38333) Migration doc for audit json log file (elastic#38165) Add apm_user reserved role (elastic#38206)
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Feb 6, 2019
In elastic#38333 and elastic#38350 we moved away from the `discovery.zen` settings namespace since these settings have an effect even though Zen Discovery itself is being phased out. This change aligns the documentation and the names of related classes and methods with the newly-introduced naming conventions.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Oct 7, 2021
Zen discovery and its associated settings were deprecated in 7.0. This commit adds an entry to the release notes calling this out. Relates elastic#38289 elastic#38333 elastic#38350 elastic#37868
DaveCTurner
added a commit
that referenced
this pull request
Oct 7, 2021
DaveCTurner
added a commit
that referenced
this pull request
Oct 10, 2021
DaveCTurner
added a commit
that referenced
this pull request
Oct 10, 2021
DaveCTurner
added a commit
that referenced
this pull request
Oct 10, 2021
DaveCTurner
added a commit
that referenced
this pull request
Oct 10, 2021
DaveCTurner
added a commit
that referenced
this pull request
Oct 10, 2021
DaveCTurner
added a commit
that referenced
this pull request
Oct 10, 2021
DaveCTurner
added a commit
that referenced
this pull request
Oct 10, 2021
DaveCTurner
added a commit
that referenced
this pull request
Oct 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the following settings to remove the mention of
zenin their names:discovery.zen.hosts_provider->discovery.seed_providersdiscovery.zen.ping.unicast.concurrent_connects->discovery.seed_resolver.max_concurrent_resolversdiscovery.zen.ping.unicast.hosts.resolve_timeout->discovery.seed_resolver.timeoutdiscovery.zen.ping.unicast.hosts->discovery.seed_hostsThe old names are still supported, but deprecated, and we reject attempts to
use both old and new names at the same time.