SQL: Allow look-ahead resolution of aliases for WHERE clause#38450
SQL: Allow look-ahead resolution of aliases for WHERE clause#38450costin merged 4 commits intoelastic:masterfrom
Conversation
Aliases defined in SELECT (Project or Aggregate) are now resolved in the following WHERE clause. The Analyzer has been enhanced to identify this rule and replace the field accordingly. Close elastic#29983
|
Pinging @elastic/es-search |
There was a problem hiding this comment.
LGTM. Nice, this typically is not supported by RDBMS (MySQL, PostgreSQL, etc.)
postgres=# SELECT emp_no AS a FROM test_emp WHERE a > 10;
ERROR: column "a" does not exist
LINE 1: SELECT emp_no AS a FROM test_emp WHERE a > 10; ^
The reason is that SELECT is supposed to wrap the FROM t WHERE... so WHERE is unaware of the projection. But anyway, it's handy for the user to have it.
| import static java.util.Collections.emptyMap; | ||
| import static java.util.Collections.singletonMap; | ||
|
|
||
| @TestLogging("org.elasticsearch.xpack.sql:TRACE") |
| } | ||
|
|
||
| private Expression replaceAliases(Expression condition, List<? extends NamedExpression> named) { | ||
| List<Alias> aliases = new ArrayList<>(); |
There was a problem hiding this comment.
Wouldn't be more efficient to have a Map<String, Alias> where the key is the alias.name() and avoid iteration over a list?
There was a problem hiding this comment.
Actually scratch that - it's not that easy due to the qualifier which might be present or not. I'll update the resolution though.
|
|
||
| return condition.transformDown(u -> { | ||
| for (Alias alias : aliases) { | ||
| if (alias.name().equals(u.name()) || Objects.equals(alias.qualifiedName(), u.qualifiedName())) { |
There was a problem hiding this comment.
Is there a case where the names are not equal but the qualifiedName() are equal?
Couldn't we check just the qualifiedName()?
If there is such case can we have it in a test?
There was a problem hiding this comment.
An alias can be qualified as part of a subquery - the qualifiedName doesn't work in cases where one side is qualified the other isn't (the names are equal by one of the qualifier is missing).
I couldn't come up with a test case however I've updated the comparison to be in sync with that of the identifier resolution (in simplified form).
|
@elasticmachine run elasticsearch-ci/2 |
|
@gingerwizard FYI |
…on-leases-recovery * elastic/master: SQL: Allow look-ahead resolution of aliases for WHERE clause (elastic#38450) Add API key settings documentation (elastic#38490) Remove support for maxRetryTimeout from low-level REST client (elastic#38085) Update IndexTemplateMetaData to allow unknown fields (elastic#38448) Mute testRetentionLeasesSyncOnRecovery (elastic#38488) Change the min supported version to 6.7.0 for API keys (elastic#38481)
5 participants
Aliases defined in SELECT (Project or Aggregate) are now resolved in the
following WHERE clause. The Analyzer has been enhanced to identify this
rule and replace the field accordingly so that queries such as:
SELECT int AS i FROM t WHERE i > 10
Do not fail anymore (as i was unresolved inside the
WHEREclause).Close #29983