Fix the clock resolution to millis in ScheduledEventTests#38506
Merged
droberts195 merged 1 commit intoelastic:masterfrom Feb 6, 2019
Merged
Conversation
The clock resolution changed from jdk8 to jdk10, hence the test is passing in jdk8 but failing in jdk10. Scheduled events are serialised and deserialised with millisecond precision, making test fail in jdk 10 and higher. Fixes a problem introduced by elastic#38415 and the fix is identical to the one that was made in elastic#38405.
Collaborator
|
Pinging @elastic/ml-core |
droberts195
commented
Feb 6, 2019
| } | ||
| } | ||
|
|
||
| private static ZonedDateTime nowWithMillisResolution() { |
Author
There was a problem hiding this comment.
Should we factor this out into a base class now it's used in two places (the other is GetWatchResponseTests)? ESTestCase? What do you think @spinscale?
Contributor
There was a problem hiding this comment.
this is very tempting as x-pack/sql is already doing the same (in a slightly different way)
#36877
pgomulka
approved these changes
Feb 6, 2019
Contributor
pgomulka
left a comment
pgomulka
left a comment
There was a problem hiding this comment.
LGTM
we might want to refactor the nowWithMillisResolution in some common place - DateUtils? But I guess better to do this in a separate PR touching watcher, sql and ML (will create an issue to remember about this)
Author
Yes, agreed, especially now this PR has passed all checks. I will merge it now to minimise build failures. |
droberts195
deleted the
millisecond_accuracy_for_scheduled_event_tests
branch
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Feb 6, 2019
) The clock resolution changed from jdk8 to jdk10, hence the test is passing in jdk8 but failing in jdk10. Scheduled events are serialised and deserialised with millisecond precision, making test fail in jdk 10 and higher. Fixes a problem introduced by elastic#38415 and the fix is identical to the one that was made in elastic#38405.
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Feb 6, 2019
) The clock resolution changed from jdk8 to jdk10, hence the test is passing in jdk8 but failing in jdk10. Scheduled events are serialised and deserialised with millisecond precision, making test fail in jdk 10 and higher. Fixes a problem introduced by elastic#38415 and the fix is identical to the one that was made in elastic#38405.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Feb 6, 2019
* master: ML: update set_upgrade_mode, add logging (elastic#38372) bad formatted JSON object (elastic#38515) (elastic#38525) Fix HistoryIntegrationTests timestamp comparsion (elastic#38505) SQL: Fix issue with IN not resolving to underlying keyword field (elastic#38440) Fix the clock resolution to millis in ScheduledEventTests (elastic#38506)
alpar-t
pushed a commit
to jasontedor/elasticsearch
that referenced
this pull request
Feb 7, 2019
) The clock resolution changed from jdk8 to jdk10, hence the test is passing in jdk8 but failing in jdk10. Scheduled events are serialised and deserialised with millisecond precision, making test fail in jdk 10 and higher. Fixes a problem introduced by elastic#38415 and the fix is identical to the one that was made in elastic#38405.
droberts195
added a commit
that referenced
this pull request
Feb 8, 2019
The clock resolution changed from jdk8 to jdk10, hence the test is passing in jdk8 but failing in jdk10. Scheduled events are serialised and deserialised with millisecond precision, making test fail in jdk 10 and higher. Fixes a problem introduced by #38415 and the fix is identical to the one that was made in #38405. Backport of #38506
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Feb 11, 2019
* master: (27 commits) Mute AnalysisModuleTests#testStandardFilterBWC (elastic#38636) add geotile_grid ref to asciidoc (elastic#38632) Enable Dockerfile from artifacts.elastic.co (elastic#38552) Mute FollowerFailOverIT testFailOverOnFollower (elastic#38634) Account for a possible rolled over file while reading the audit log file (elastic#34909) Mute failure in InternalEngineTests (elastic#38622) Fix Issue with Concurrent Snapshot Init + Delete (elastic#38518) Refactor ZonedDateTime.now in millis resolution (elastic#38577) Mute failing WatchStatusIntegrationTests (elastic#38621) Mute failing ApiKeyIntegTests (elastic#38614) [DOCS] Add warning about bypassing ML PUT APIs (elastic#38509) Add 7.1 and 8.0 version constants to master (elastic#38514) ML: update set_upgrade_mode, add logging (elastic#38372) bad formatted JSON object (elastic#38515) (elastic#38525) Fix HistoryIntegrationTests timestamp comparsion (elastic#38505) SQL: Fix issue with IN not resolving to underlying keyword field (elastic#38440) Fix the clock resolution to millis in ScheduledEventTests (elastic#38506) Enable BWC after backport recovering leases (elastic#38485) Collapse retention lease integration tests (elastic#38483) TransportVerifyShardBeforeCloseAction should force a flush (elastic#38401) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The clock resolution changed from jdk8 to jdk10, hence the
test is passing in jdk8 but failing in jdk10. Scheduled
events are serialised and deserialised with millisecond
precision, making test fail in jdk 10 and higher.
Fixes a problem introduced by #38415 and the fix is
identical to the one that was made in #38405.