Closed
Conversation
Member
|
Just a heads-up that there's a booby-trap here: I am working on a commit that deletes the offending code. |
Member
|
When you're ready, you can cherry-pick 1898ee4776c541e0c2a5b4428f64aaa5dacb8164 which removes the Zen1 BWC infrastructure that this assertion asserts to be absent. You may need to fetch that from my fork: https://github.com/DaveCTurner/elasticsearch/tree/2019-02-06-remove-zen1-bwc |
Member
|
I ported all these commits over to #38514. Thanks all for the contributions, let's continue the effort there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains changes in #38513 as well.