Add seqNo related assertions to TokenService#38563
Merged
bleskes merged 1 commit intoelastic:6.7from Feb 11, 2019
Merged
Conversation
These were suggested by @albertzaharovits in elastic#38311 (review)
bleskes
added
>non-issue
:Security/Authentication
Collaborator
|
Pinging @elastic/es-security |
albertzaharovits
approved these changes
Feb 11, 2019
Contributor
albertzaharovits
left a comment
albertzaharovits
left a comment
There was a problem hiding this comment.
LGTM Thanks for the follow up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were suggested by @albertzaharovits in #38311 (review)