Skip to content

Fix synchronization in LocalCheckpointTracker#contains#38755

Merged
dnhatn merged 1 commit intoelastic:masterfrom
dnhatn:fix-checkpoint-tracker-contains
Feb 12, 2019
Merged

Fix synchronization in LocalCheckpointTracker#contains#38755
dnhatn merged 1 commit intoelastic:masterfrom
dnhatn:fix-checkpoint-tracker-contains

Conversation

@dnhatn
Copy link
Copy Markdown
Member

@dnhatn dnhatn commented Feb 11, 2019

While investigating #38633, I realize that we are accessing a CountedBitSet in LocalCheckpointTracker#contains without proper synchronization.

Relates #33871

@dnhatn dnhatn added >bug v7.0.0 :Distributed/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. v6.7.0 v8.0.0 v7.2.0 labels Feb 11, 2019
@dnhatn dnhatn requested review from jasontedor and ywelsch February 11, 2019 23:06
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-distributed

@dnhatn dnhatn added the v6.6.1 label Feb 11, 2019
@dnhatn
Copy link
Copy Markdown
Member Author

dnhatn commented Feb 12, 2019

Thanks @ywelsch

@dnhatn dnhatn merged commit 90e6fb0 into elastic:master Feb 12, 2019
@dnhatn dnhatn deleted the fix-checkpoint-tracker-contains branch February 12, 2019 16:06
dnhatn added a commit that referenced this pull request Feb 12, 2019
We are accessing the `CountedBitSet` in `LocalCheckpointTracker#contains`
without proper synchronization.

Relates #33871
dnhatn added a commit that referenced this pull request Feb 12, 2019
We are accessing the `CountedBitSet` in `LocalCheckpointTracker#contains`
without proper synchronization.

Relates #33871
dnhatn added a commit that referenced this pull request Feb 12, 2019
We are accessing the `CountedBitSet` in `LocalCheckpointTracker#contains`
without proper synchronization.

Relates #33871
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 13, 2019
* master:
  Remove _type term filters from cluster alert watches (elastic#38819)
  Adjust log and unmute testFailOverOnFollower (elastic#38762)
  Fix line separators in JSON logging tests (elastic#38771)
  Fix synchronization in LocalCheckpointTracker#contains (elastic#38755)
  muted test
  Remove TLSv1.2 pinning in ssl reload tests (elastic#38651)
  Don't fail init script if `/proc/.../max_map_count` absent (elastic#35933)
  Format Watcher.status.lastChecked and lastMetCondition (elastic#38626)
  SQL: Implement `::` cast operator (elastic#38774)
  Ignore failing test
mfussenegger added a commit to crate/crate that referenced this pull request Sep 30, 2019
mfussenegger added a commit to crate/crate that referenced this pull request Sep 30, 2019
mergify bot pushed a commit to crate/crate that referenced this pull request Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>bug :Distributed/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. v6.6.1 v6.7.0 v7.0.0-rc1 v7.2.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants