ML refactor DatafeedsConfig(Update) so defaults are not populated in …#39119
Merged
benwtrent merged 1 commit intoelastic:7.xfrom Feb 19, 2019
Merged
Conversation
…queries or aggs (elastic#38822) * ML refactor DatafeedsConfig(Update) so defaults are not populated in queries or aggs * Addressing pr feedback
Collaborator
|
Pinging @elastic/ml-core |
Member
Author
|
please run elasticsearch-ci/bwc |
benwtrent
deleted the
feature/ml-datafeeds-only-store-user-agg-query-7.x
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have decided that when we lazily parse and store configurations for
queryoraggsin are various models, we should store specifically what the user sent us and none of the auto-generated defaults created from parsing.There are also some various refactors lazy parsing for datafeeds in general.
Backport of: #38822