minor updates for user-agent ecs for 6.7#39213
Merged
jakelandis merged 5 commits intoelastic:6.7from Feb 21, 2019
Merged
Conversation
PR elastic#38757 changed 7.0 user-agent behavior for the ecs flag to more closely resemble 6.7. This commit updates the forward looking comments and deprecation notices to be more accurate now that this flag will not be removed until 8.0 related elastic#38757
jakelandis
added
:Distributed/Ingest Node
Collaborator
|
Pinging @elastic/es-core-features |
AthenaEryma
reviewed
Feb 21, 2019
...ecation/src/test/java/org/elasticsearch/xpack/deprecation/ClusterDeprecationChecksTests.java
Outdated
Show resolved
Hide resolved
AthenaEryma
approved these changes
Feb 21, 2019
Contributor
AthenaEryma
left a comment
AthenaEryma
left a comment
There was a problem hiding this comment.
LGTM with one maybe-nitpick.
…k/deprecation/ClusterDeprecationChecksTests.java Co-Authored-By: jakelandis <jake.landis@elastic.co>
dakrone
approved these changes
Feb 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #38757 changed 7.0 user-agent behavior for the ecs flag
to more closely resemble 6.7. This commit updates the forward
looking comments and deprecation notices to be more accurate
now that this flag will not be removed until 8.0
related #38757