Extract TransportRequestDeduplication from ShardStateAction (#37870)#39399
Merged
original-brownbear merged 1 commit intoelastic:6.7from Feb 26, 2019
original-brownbear:37870-6.7
Merged
Extract TransportRequestDeduplication from ShardStateAction (#37870)#39399original-brownbear merged 1 commit intoelastic:6.7from original-brownbear:37870-6.7
original-brownbear merged 1 commit intoelastic:6.7from
original-brownbear:37870-6.7
Conversation
* Extracted the logic for master request duplication so it can be reused by the snapshotting logic * Removed custom listener used by `ShardStateAction` to not leak these into future users of this class * Changed semantics slightly to get rid of redundant instantiations of the composite listener * Relates #37686
original-brownbear
added
:Distributed/Distributed
Collaborator
|
Pinging @elastic/es-distributed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ShardStateActionto not leak these into future users of this classback porting this as a prerequisite of snapshot fix back ports