Merged
Conversation
droberts195
added
>test
Collaborator
|
Pinging @elastic/ml-core |
|
For the benefit of anyone else who looks at this and wonders why that test isn't changed to assert an error response from the server, the answer is that there is a test that does exactly that immediately above the deleted one. I think the test that asserted that a client-side error would be triggered must have been a cut-and-paste error at the time the test file was first created. And when running in the ES build system the framework ignores the results of tests that are supposed to trigger a client-side error, which is why it doesn't cause ES builds to fail. It only causes problems for the client testing. |
droberts195
pushed a commit
that referenced
this pull request
Mar 5, 2019
A client cannot know that a job_id is already taken, so this test should not have been specified as a client test
droberts195
pushed a commit
that referenced
this pull request
Mar 5, 2019
A client cannot know that a job_id is already taken, so this test should not have been specified as a client test
droberts195
pushed a commit
that referenced
this pull request
Mar 5, 2019
A client cannot know that a job_id is already taken, so this test should not have been specified as a client test
droberts195
pushed a commit
that referenced
this pull request
Mar 5, 2019
A client cannot know that a job_id is already taken, so this test should not have been specified as a client test
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Mar 6, 2019
* 6.7: (39 commits) Remove beta label from CCR (elastic#39722) Rename retention lease setting (elastic#39719) Add Docker build type (elastic#39378) Use any index specified by .watches for Watcher (elastic#39541) (elastic#39706) Add documentation on remote recovery (elastic#39483) fix typo in synonym graph filter docs Removed incorrect ML YAML tests (elastic#39400) Improved Terms Aggregation documentation (elastic#38892) Fix Fuzziness#asDistance(String) (elastic#39643) Revert "unmute EvilLoggerTests#testDeprecatedSettings (elastic#38743)" Mute TokenAuthIntegTests.testExpiredTokensDeletedAfterExpiration (elastic#39690) Fix security index auto-create and state recovery race (elastic#39582) [DOCS] Sorts security APIs Check for .watches that wasn't upgraded properly (elastic#39609) Assert recovery done in testDoNotWaitForPendingSeqNo (elastic#39595) [DOCS] Updates API in Watcher transform context (elastic#39540) Fixing the custom object serialization bug in diffable utils. (elastic#39544) mute test SQL: Don't allow inexact fields for MIN/MAX (elastic#39563) Update release notes for 6.7.0 ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no need for this test since the clients will only validate parameters, and not logic/state (eg, a client cannot know that the
job_idis already taken).cc @elastic/es-clients