Skip to content

Give jspawnhelper execute permissions in bundled JDK#39787

Merged
droberts195 merged 1 commit intoelastic:masterfrom
droberts195:chmod_plus_x_jspawnhelper
Mar 7, 2019
Merged

Give jspawnhelper execute permissions in bundled JDK#39787
droberts195 merged 1 commit intoelastic:masterfrom
droberts195:chmod_plus_x_jspawnhelper

Conversation

@droberts195
Copy link
Copy Markdown

The posix_spawn method of launching a process from Java
goes via an intermediate process called jspawnhelper
which lives in the lib directory rather than the bin
directory and hence got missed by the original chmod
loop. This change adds jspawnhelper as a special case.
It's the only program that's in the lib directory in a
macOS JDK 11.

The posix_spawn method of launching a process from Java
goes via an intermediate process called jspawnhelper
which lives in the lib directory rather than the bin
directory and hence got missed by the original chmod
loop.  This change adds jspawnhelper as a special case.
It's the only program that's in the lib directory in a
macOS JDK 11.
@droberts195 droberts195 added >non-issue :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts v8.0.0 labels Mar 7, 2019
@droberts195 droberts195 requested a review from rjernst March 7, 2019 13:00
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-infra

@droberts195
Copy link
Copy Markdown
Author

I marked this as >non-issue because it doesn't need to be release noted separately to #38013.

And I marked in v8.0.0 only because hopefully it can be incorporated into #39709 and #39710 which are still unmerged. (But if you'd prefer me to cherry-pick this fix separately after those are merged then I can do that.)

@droberts195
Copy link
Copy Markdown
Author

Jenkins run elasticsearch-ci/packaging-sample

@droberts195
Copy link
Copy Markdown
Author

Jenkins run elasticsearch-ci/packaging

Copy link
Copy Markdown
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link
Copy Markdown
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@droberts195 droberts195 merged commit 7e10732 into elastic:master Mar 7, 2019
@droberts195 droberts195 deleted the chmod_plus_x_jspawnhelper branch March 7, 2019 18:53
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Mar 8, 2019
* elastic/master:
  Add pre-upgrade check to test cluster routing allocation is enabled (elastic#39340)
  Update logstash-management.json to use typeless template (elastic#38653)
  Small simplifications to mapping validation. (elastic#39777)
  Update distribution build instructions to reflect file names with OS/architecture classifiers. (elastic#39762)
  Give jspawnhelper execute permissions in bundled JDK (elastic#39787)
  Maintain step order for ILM trace logging (elastic#39522)
  [ML-DataFrame] fix wire serialization issues in data frame response objects (elastic#39790)
  fix index refresh in test within 20_mix_typeless_typeful (elastic#39198)
  Combine overriddenOps and skippedOps in translog (elastic#39771)
rjernst pushed a commit that referenced this pull request Mar 8, 2019
The posix_spawn method of launching a process from Java
goes via an intermediate process called jspawnhelper
which lives in the lib directory rather than the bin
directory and hence got missed by the original chmod
loop.  This change adds jspawnhelper as a special case.
It's the only program that's in the lib directory in a
macOS JDK 11.
rjernst pushed a commit that referenced this pull request Mar 8, 2019
The posix_spawn method of launching a process from Java
goes via an intermediate process called jspawnhelper
which lives in the lib directory rather than the bin
directory and hence got missed by the original chmod
loop.  This change adds jspawnhelper as a special case.
It's the only program that's in the lib directory in a
macOS JDK 11.
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts >non-issue Team:Delivery Meta label for Delivery team v7.0.0-rc2 v7.2.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants