Fix token Invalidation when retries exhausted#39799
Merged
albertzaharovits merged 2 commits intoelastic:masterfrom Mar 8, 2019
Merged
Fix token Invalidation when retries exhausted#39799albertzaharovits merged 2 commits intoelastic:masterfrom
albertzaharovits merged 2 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-security |
Contributor
Author
|
both https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+pull-request+default-distro/8166/consoleFull and https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+pull-request-bwc/1448/consoleFull are plagued by: In a multitude of independent tests. I'm going to assume a transient network failure. |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/default-distro |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/bwc |
Contributor
Author
|
The failures were utterly alien and I think they were due to the #39512 missing in the PR . I have merged master in. |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/bwc |
Contributor
Author
|
For https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+pull-request-bwc/1539/console I have raised https://github.com/elastic/infra/issues/9993 |
albertzaharovits
added a commit
that referenced
this pull request
Mar 8, 2019
Fixes an error about missing to call the index invalidation listener when retry count is exhausted but there are still tokens to be retried.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a glitch that misses to call the index invalidation listener, when retry count is exhausted and there are still tokens to be retried.
I recommend the split diff to better visualize the change