Deprecate size in cluster state response#39951
Closed
DaveCTurner wants to merge 5 commits intoelastic:masterfrom
Closed
Deprecate size in cluster state response#39951DaveCTurner wants to merge 5 commits intoelastic:masterfrom
DaveCTurner wants to merge 5 commits intoelastic:masterfrom
Conversation
Today when we respond to a `cluster:monitor/state` action we serialize the current cluster state on the network thread in order to return its size when compressed. This serialization can be expensive if the cluster state is very large. Yet the size we return is not a useful number to report to clients. We plan to remove the size from the cluster state response because it is not a useful number to report to clients. This is the first step, in which the size computation becomes optional and deprecated. Relates elastic#39806
DaveCTurner
added
>deprecation
v7.0.0
:Distributed/Cluster Coordination
Collaborator
|
Pinging @elastic/es-distributed |
ywelsch
suggested changes
Mar 12, 2019
Contributor
ywelsch
left a comment
ywelsch
left a comment
There was a problem hiding this comment.
I don't think this is the right path forward and will lead to a very poor experience when upgrading as a user.
This was referenced Mar 13, 2019
Member
|
We are taking a different approach. See #40016 and #40061. Thank you @DaveCTurner for identifying the underlying issue and kickstarting the thinking and effort that got us to a solution we are comfortable with. |
DaveCTurner
deleted the
2019-03-12-deprecate-compressed-cluster-state-size
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today when we respond to a
cluster:monitor/stateaction we serialize thecurrent cluster state on the network thread in order to return its size when
compressed. This serialization can be expensive if the cluster state is very
large. Yet the size we return is not a useful number to report to clients.
We plan to remove the size from the cluster state response because it is not a
useful number to report to clients. This is the first step, in which the size
computation becomes optional and deprecated.
Relates #39806