[Test] Modify assert statement for ssl handshake (#32072)#40530
Merged
benwtrent merged 1 commit intoelastic:6.7from Mar 27, 2019
Merged
[Test] Modify assert statement for ssl handshake (#32072)#40530benwtrent merged 1 commit intoelastic:6.7from
benwtrent merged 1 commit intoelastic:6.7from
Conversation
There have been changes in error messages for `SSLHandshakeException`. This has caused a couple of failures in our tests. This commit modifies test verification to assert on exception type of class `SSLHandshakeException`. There was another issue in Java11 which caused NPE. The bug has now been fixed on Java11 - early access build 22. Bug Ref: https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8206355 Enable the skipped tests due to this bug. Closes elastic#31940
benwtrent
added
>test
Collaborator
|
Pinging @elastic/es-security |
Member
Author
|
Previous PR that was backported to 7.0, 7.x #32072 |
jaymode
approved these changes
Mar 27, 2019
Member
Author
|
run elasticsearch-ci/packaging-sample |
Member
Author
|
run elasticsearch-ci/2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There have been changes in error messages for
SSLHandshakeException.This has caused a couple of failures in our tests.
This commit modifies test verification to assert on exception type of
class
SSLHandshakeException.There was another issue in Java11 which caused NPE. The bug has now
been fixed on Java11 - early access build 22.
Bug Ref: https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8206355
Enable the skipped tests due to this bug.
Closes #31940
This test now fails in the Java12 builds of the 6.7 branch as we only checked for Java 11 when assuming the failure.
Backporting the fix made by @bizybot into 6.7