SQL: Fix display size for DATE/DATETIME#40669
Merged
matriv merged 4 commits intoelastic:masterfrom Apr 3, 2019
Merged
Conversation
A full format for a DATETIME would be: `2019-03-30T10:20:30.123456789+10:00` (example when asking for `current_timestamp(9)`) which is 35 chars long. For DATE a full format would be: `2019-03-30T00:00:00.000+10:00` which is 29 chars long.
matriv
added
>bug
v7.0.0
:Analytics/SQL
Collaborator
|
Pinging @elastic/es-search |
matriv
changed the title
astefan
approved these changes
Apr 1, 2019
Contributor
astefan
left a comment
astefan
left a comment
There was a problem hiding this comment.
LGTM. Left a comment about the protocol tests.
| public void testDateTimes() throws IOException { | ||
| assertQuery("SELECT CAST('2019-01-14T12:29:25.000Z' AS DATETIME)", "CAST('2019-01-14T12:29:25.000Z' AS DATETIME)", | ||
| "datetime", "2019-01-14T12:29:25.000Z", 24); | ||
| "datetime", "2019-01-14T12:29:25.000Z", 35); |
Contributor
There was a problem hiding this comment.
Since the precision changed, please change the tests' values or add new tests (preferred) to reflect the increased precision.
Contributor
Author
There was a problem hiding this comment.
Unfortunately this revealed another bug: #40692
so currently I cannot have easily a test with custom timezone.
Currently we only display down to millis.
Contributor
Author
|
/cc @bpintea We keep the precision of second fractional digits to 3 as currently we never return more than that. Added a comment to docs regarding |
astefan
reviewed
Apr 1, 2019
| NESTED( "nested", JDBCType.STRUCT, -1, 0, 0, false, false, false), | ||
| BINARY( "binary", JDBCType.VARBINARY, -1, Integer.MAX_VALUE, Integer.MAX_VALUE, false, false, false), | ||
| DATE( JDBCType.DATE, Long.BYTES, 24, 24, false, false, true), | ||
| DATE( JDBCType.DATE, Long.BYTES, 3, 29, false, false, true), |
Contributor
There was a problem hiding this comment.
The precision here (3) and the comment below (about display size and precision) are incompatible I think.
Contributor
Author
There was a problem hiding this comment.
The 3 shows how many second fractional digits are used. currently millis -> 3. This was fixed here: 1557d77#diff-a3aa9a4b764c281befa4ee231082c298R51
Contributor
There was a problem hiding this comment.
Ok. Thanks. Then the code comment is inaccurate or not necessary?
- The precision is not 23 + 1 anymore
- the timezone is not Z only anymore
Contributor
Author
There was a problem hiding this comment.
Ah, yes. Thx will fix it.
astefan
approved these changes
Apr 1, 2019
Contributor
astefan
left a comment
astefan
left a comment
There was a problem hiding this comment.
LGTM, but I left a comment.
matriv
added a commit
that referenced
this pull request
Apr 3, 2019
A full format for a DATETIME would be: `2019-03-30T10:20:30.123+10:00` which is 29 chars long. For DATE a full format would be: `2019-03-30T00:00:00.000+10:00` which is also 29 chars long. (cherry picked from commit 6be8396)
matriv
added a commit
that referenced
this pull request
Apr 3, 2019
A full format for a DATETIME would be: `2019-03-30T10:20:30.123+10:00` which is 29 chars long. For DATE a full format would be: `2019-03-30T00:00:00.000+10:00` which is also 29 chars long. (cherry picked from commit 6be8396)
matriv
added a commit
that referenced
this pull request
Apr 3, 2019
A full format for a DATETIME would be: `2019-03-30T10:20:30.123+10:00` which is 29 chars long. For DATE a full format would be: `2019-03-30T00:00:00.000+10:00` which is also 29 chars long. (cherry picked from commit 6be8396)
matriv
added a commit
that referenced
this pull request
Apr 3, 2019
A full format for a DATETIME would be: `2019-03-30T10:20:30.123+10:00` which is 29 chars long. For DATE a full format would be: `2019-03-30T00:00:00.000+10:00` which is also 29 chars long. (cherry picked from commit 6be8396)
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Apr 3, 2019
…leniency * elastic/master: SQL: Fix deserialisation issue of TimeProcessor (elastic#40776) Improve GCS docs for using keystore (elastic#40605) Add Restore Operation to SnapshotResiliencyTests (elastic#40634) Small refactorings to analysis components (elastic#40745) SQL: Fix display size for DATE/DATETIME (elastic#40669) add HLRC protocol tests for transform state and stats (elastic#40766) Inline TransportReplAction#registerRequestHandlers (elastic#40762) remove experimental label from search_as_you_type documentation (elastic#40744) Remove some abstractions from `TransportReplicationAction` (elastic#40706) Upgrade to latest build scan plugin (elastic#40702) Use default memory lock setting in testing (elastic#40730) Add Bulk Delete Api to BlobStore (elastic#40322) Remove yaml skips older than 7.0 (elastic#40183) Docs: Move id in the java-api (elastic#40748)
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
A full format for a DATETIME would be: `2019-03-30T10:20:30.123+10:00` which is 29 chars long. For DATE a full format would be: `2019-03-30T00:00:00.000+10:00` which is also 29 chars long.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A full format for a DATETIME would be:
2019-03-30T10:20:30.123456789+10:00(example when asking forcurrent_timestamp(9)) which is 35 chars long.For DATE a full format would be:
2019-03-30T00:00:00.000+10:00which is 29 chars long.