Fix Failing to Handle Ex. in TransportShardBulkAction#40923
Merged
original-brownbear merged 2 commits intoelastic:masterfrom Apr 7, 2019
original-brownbear:fix-missed-catch
Merged
Fix Failing to Handle Ex. in TransportShardBulkAction#40923original-brownbear merged 2 commits intoelastic:masterfrom original-brownbear:fix-missed-catch
original-brownbear merged 2 commits intoelastic:masterfrom
original-brownbear:fix-missed-catch
Conversation
* Fixing minor mistake from #39793 here, we should be using `run` so that the `onFailure` path is executed if the first invocation of this `Runnable` fails for an unexpected reason
original-brownbear
added
>non-issue
:Distributed/Distributed
Collaborator
|
Pinging @elastic/es-distributed |
dnhatn
approved these changes
Apr 6, 2019
Contributor
Author
|
thanks @dnhatn ! |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Apr 7, 2019
* elastic/master: Fix Failing to Handle Ex. in TransportShardBulkAction (elastic#40923) Be lenient when parsing build flavor and type on the wire (elastic#40734) Make Transport Shard Bulk Action Async (elastic#39793)
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Apr 7, 2019
…nteg-tests * elastic/master: Mute failing IndexShard local history test Fix Failing to Handle Ex. in TransportShardBulkAction (elastic#40923)
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
* Fixing minor mistake from elastic#39793 here, we should be using `run` so that the `onFailure` path is executed if the first invocation of this `Runnable` fails for an unexpected reason
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runso that theonFailurepath is executed if the first invocation of thisRunnablefails for an unexpected reason