Simplify Snapshot Resiliency Test#40930
Merged
original-brownbear merged 2 commits intoelastic:masterfrom Apr 11, 2019
original-brownbear:simplify-snapshot-resiliency-test
Merged
Simplify Snapshot Resiliency Test#40930original-brownbear merged 2 commits intoelastic:masterfrom original-brownbear:simplify-snapshot-resiliency-test
original-brownbear merged 2 commits intoelastic:masterfrom
original-brownbear:simplify-snapshot-resiliency-test
Conversation
Contributor
original-brownbear
commented
Apr 7, 2019
original-brownbear
commented
- Thanks to Make Transport Shard Bulk Action Async #39793 dynamic mapping updates don't contain blocking operations anymore so we don't have to manually put the mapping in this test and can keep it a little simpler
* Thanks to #39793 dynamic mapping updates don't contain blocking operations anymore so we don't have to manually put the mapping in this test and can keep it a little simpler
original-brownbear
added
>test
Collaborator
|
Pinging @elastic/es-distributed |
Contributor
Author
|
Jenkins run elasticsearch-ci/2 |
Contributor
Author
|
Jenkins run elasticsearch-ci/1 |
DaveCTurner
approved these changes
Apr 11, 2019
Member
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
LGTM, took me a while to understand it tho :)
The call-backs in these tests are rather too heavily nested for my taste, but that's a debate for another time.
Contributor
Author
|
@DaveCTurner thanks!
+1, but at least we got rid of one of them now :D |
original-brownbear
added a commit
that referenced
this pull request
Apr 26, 2019
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
* Thanks to elastic#39793 dynamic mapping updates don't contain blocking operations anymore so we don't have to manually put the mapping in this test and can keep it a little simpler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.