Removes typed URLs from mapping APIs#41676
Merged
romseygeek merged 15 commits intoelastic:masterfrom Sep 23, 2019
colings86:types-removal/mappings-urls
Merged
Removes typed URLs from mapping APIs#41676romseygeek merged 15 commits intoelastic:masterfrom colings86:types-removal/mappings-urls
romseygeek merged 15 commits intoelastic:masterfrom
colings86:types-removal/mappings-urls
Conversation
colings86
added
>breaking
:Search Foundations/Mapping
Collaborator
|
Pinging @elastic/es-search |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/packaging-sample |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/default-distro |
jpountz
suggested changes
May 28, 2019
Contributor
jpountz
left a comment
jpountz
left a comment
There was a problem hiding this comment.
I left some questions/comments.
server/src/main/java/org/elasticsearch/rest/action/admin/indices/RestGetFieldMappingAction.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine run elasticsearch-ci/2 |
Contributor
Author
|
@elasticmachine update branch |
jpountz
approved these changes
Sep 12, 2019
Contributor
jpountz
left a comment
jpountz
left a comment
There was a problem hiding this comment.
LGTM, sorry I let it wait for a review for so long.
Contributor
|
@elasticmachine run elasticsearch-ci/docs-check |
Contributor
|
@colings86 @romseygeek it looks like we removed many mixed typed/ typeless tests in this PR, such as
|
66 tasks
pgomulka
added a commit
that referenced
this pull request
Jul 14, 2020
based on pgomulka:compat/delete_update #58246 CompatRestIT. test {yaml=indices.get_field_mapping/30_missing_type/Raise 404 when type doesn't exist} because of that change (custom type to _doc) a test that was expecting 404 for a type that did not exist, passes now as the logic is trying to fetch for _doc (any type that exist on that index will be good). CompatRestIT. test {yaml=indices.get_mapping/11_basic_with_types/Get /{index}/_mapping with empty mappings} this is because I can't tell if the mapping contained a type or not when fetching a mapping. CompatRestIT. test {yaml=indices.get_mapping/20_missing_type/Existent and non-existent type returns 404 and the existing type} CompatRestIT. test {yaml=indices.get_mapping/20_missing_type/Existent and non-existent types returns 404 and the existing type} CompatRestIT. test {yaml=indices.get_mapping/20_missing_type/No type matching pattern returns 404} CompatRestIT. test {yaml=indices.get_mapping/20_missing_type/Non-existent type returns 404} failing - (not returning 404) - because type is always found (defaulted to _doc) CompatRestIT. test {yaml=indices.get_mapping/20_missing_type/Type missing when no types exist} CompatRestIT. test {yaml=indices.get_mapping/61_empty_with_types/Check empty mapping when getting all mappings via /_mapping} CompatRestIT. test {yaml=indices.get_template/11_basic_with_types/Get template with no mappings} CompatRestIT. test {yaml=indices.get_template/11_basic_with_types/Get template} CompatRestIT. test {yaml=indices.put_mapping/20_mix_typeless_typeful/PUT mapping with _doc on an index that has types} CompatRestIT. test {yaml=indices.put_mapping/20_mix_typeless_typeful/PUT mapping with typeless API on an index that has types} #47364 #41676
80 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.