Implement Bulk Deletes for GCS Repository (#41368)#41681
Merged
original-brownbear merged 2 commits intoelastic:7.xfrom Apr 30, 2019
original-brownbear:41368-7.x
Merged
Implement Bulk Deletes for GCS Repository (#41368)#41681original-brownbear merged 2 commits intoelastic:7.xfrom original-brownbear:41368-7.x
original-brownbear merged 2 commits intoelastic:7.xfrom
original-brownbear:41368-7.x
Conversation
* Implement Bulk Deletes for GCS Repository * Just like #40322 for AWS * We already had a bulk delete API but weren't using it from the blob container implementation, now we are using it * Made the bulk delete API also compliant with our interface that only suppresses errors about non existent blobs by stating failed deletes (I didn't use any bulk stat action here since having to stat here should be the exception anyway and it would make error handling a lot more complex) * Fixed bulk delete API to limit its batch size to 100 in line with GCS recommendations
original-brownbear
added
>enhancement
:Distributed/Snapshot/Restore
Collaborator
|
Pinging @elastic/es-distributed |
Contributor
Author
|
Jenkins run elasticsearch-ci/1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement Bulk Deletes for GCS Repository
Just like Add Bulk Delete Api to BlobStore #40322 for AWS
We already had a bulk delete API but weren't using it from the blob container implementation, now we are using it
Fixed bulk delete API to limit its batch size to 100 in line with GCS recommendations
back port of #41368