[ML-DataFrame] migrate to PageParams for get and stats, move PageParams into core#41851
Merged
hendrikmuhs merged 3 commits intoelastic:masterfrom May 7, 2019
Merged
Conversation
fix possible NPE in PageParams
Collaborator
|
Pinging @elastic/ml-core |
przemekwitek
approved these changes
May 6, 2019
przemekwitek
left a comment
przemekwitek
left a comment
There was a problem hiding this comment.
LGTM
A few minor comments, mostly around unit tests.
.../src/test/java/org/elasticsearch/client/documentation/DataFrameTransformDocumentationIT.java
Outdated
Show resolved
Hide resolved
.../rest-high-level/src/test/java/org/elasticsearch/client/DataFrameRequestConvertersTests.java
Outdated
Show resolved
Hide resolved
.../rest-high-level/src/test/java/org/elasticsearch/client/DataFrameRequestConvertersTests.java
Outdated
Show resolved
Hide resolved
.../rest-high-level/src/test/java/org/elasticsearch/client/DataFrameRequestConvertersTests.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| public int getFrom() { | ||
| public Integer getFrom() { |
There was a problem hiding this comment.
FYI, I did the same thing in feature branch:
https://github.com/elastic/elasticsearch/pull/41530/files
Author
|
run elasticsearch-ci/1 |
hendrikmuhs
pushed a commit
that referenced
this pull request
May 7, 2019
…ms into core (#41851) migrate hlrc dataframe get and _stats to use PageParams, moves PageParams into core for common usage, fix possible NPE in PageParams
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
May 7, 2019
* elastic/master: (50 commits) Cleanup versioned deprecations in analysis (elastic#41560) Allow unknown task time in QueueResizingEsTPE (elastic#41810) SQL: Remove CircuitBreaker from parser (elastic#41835) [DOCS] Fix callouts for dataframe APIs (elastic#41904) Handle serialization exceptions during publication (elastic#41781) Correct spelling of MockLogAppender.PatternSeenEventExpectation (elastic#41893) Update TLS ciphers and protocols for JDK 11 (elastic#41808) Remove Harmful Exists Check from BlobStoreFormat (elastic#41898) Fix fractional seconds for strict_date_optional_time (elastic#41871) Remove op.name configuration setting (elastic#41445) Reject port ranges in `discovery.seed_hosts` (elastic#41404) [ML-DataFrame] migrate to PageParams for get and stats, move PageParams into core (elastic#41851) Reenable RareClusterStateIT Mapping Propagation Tests (elastic#41884) [DOCS] Rewrite `exists` query docs (elastic#41868) Revert "Mute MinimumMasterNodesIT.testThreeNodesNoMasterBlock()" [DOCS] Fix typo referring to multi search API Provide names for all artifact repositories (elastic#41857) Move InternalAggregations to Writeable (elastic#41841) Fix compilation after incorrect merge Unmute TestClustersPluginIT.testMultiNode (elastic#41340) ...
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
…ms into core (elastic#41851) migrate hlrc dataframe get and _stats to use PageParams, moves PageParams into core for common usage, fix possible NPE in PageParams
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
migrates hlrc dataframe get and _stats to use PageParams, moves PageParams into core for common usage, fix possible NPE in PageParams
Note: The NPE problem is benign because ml clients send page parameters in the body, therefore still non-issue