Add documentation for calendar/fixed intervals#41919
Merged
polyfractal merged 2 commits intoelastic:masterfrom May 10, 2019
Merged
Add documentation for calendar/fixed intervals#41919polyfractal merged 2 commits intoelastic:masterfrom
polyfractal merged 2 commits intoelastic:masterfrom
Conversation
polyfractal
added
>docs
Collaborator
|
Pinging @elastic/es-analytics-geo |
talevy
reviewed
May 8, 2019
Contributor
talevy
left a comment
talevy
left a comment
There was a problem hiding this comment.
I tried reading it as a naive user, which was easy because I didn't have to pretend.
I liked it, I thought it was very clear. I just left a few comments
docs/reference/aggregations/bucket/datehistogram-aggregation.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/aggregations/bucket/datehistogram-aggregation.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/aggregations/bucket/datehistogram-aggregation.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/aggregations/bucket/datehistogram-aggregation.asciidoc
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks @talevy! Pushed a commit which addresses the review comments |
talevy
approved these changes
May 9, 2019
Contributor
talevy
left a comment
talevy
left a comment
There was a problem hiding this comment.
awesome! love the examples
polyfractal
pushed a commit
to polyfractal/elasticsearch
that referenced
this pull request
May 10, 2019
Original PR missed documentation for the new calendar/fixed intervals. This adds the missing documentation
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
May 10, 2019
* elastic/master: (84 commits) [ML] adds geo_centroid aggregation support to data frames (elastic#42088) Add documentation for calendar/fixed intervals (elastic#41919) Remove global checkpoint assertion in peer recovery (elastic#41987) Don't create tempdir for cli scripts (elastic#41913) Fix debian-8 update (elastic#42056) Cleanup plugin bin directories (elastic#41907) Prevent order being lost for _nodes API filters (elastic#42045) Change IndexAnalyzers default analyzer access (elastic#42011) Remove reference to fs.data.spins in docs Mute failing AsyncTwoPhaseIndexerTests Remove close method in PageCacheRecycler/Recycler (elastic#41917) [ML] adding pivot.max_search_page_size option for setting paging size (elastic#41920) Docs: Tweak list formatting Simplify handling of keyword field normalizers (elastic#42002) [ML] properly nesting objects in document source (elastic#41901) Remove extra `ms` from log message (elastic#42068) Increase the sample space for random inner hits name generator (elastic#42057) Recognise direct buffers in heap size docs (elastic#42070) shouldRollGeneration should execute under read lock (elastic#41696) Wait for active shard after close in mixed cluster (elastic#42029) ...
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
Original PR missed documentation for the new calendar/fixed intervals. This adds the missing documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds documentation that was missed in #33727 😱
I tried to reuse the text about the different intervals and their definitions, but I purged some of the free form text since it was hard to read and didn't really fit with the new parameters.
There is a section that mentions the old
intervalparameter, but only in passing. Wasn't sure if we wanted to fully document the now-deprecated setting or not. Seems like it would needlessly complicate the documentation imo.