Cleanup Redundant BlobStoreFormat Class#42195
Merged
original-brownbear merged 1 commit intoelastic:masterfrom May 21, 2019
original-brownbear:cleanup-redundant-abstract-class
Merged
Cleanup Redundant BlobStoreFormat Class#42195original-brownbear merged 1 commit intoelastic:masterfrom original-brownbear:cleanup-redundant-abstract-class
original-brownbear merged 1 commit intoelastic:masterfrom
original-brownbear:cleanup-redundant-abstract-class
Conversation
Contributor
original-brownbear
commented
May 17, 2019
original-brownbear
commented
- No need to have an abstract class here when there's only a single impl.
* No need to have an abstract class here when there's only a single impl.
original-brownbear
added
>non-issue
:Distributed/Snapshot/Restore
Collaborator
|
Pinging @elastic/es-distributed |
Contributor
Author
|
Jenkins run elasticsearch-ci/1 |
Contributor
Author
|
thanks @andrershov ! |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
May 22, 2019
* master: (82 commits) Fix off-by-one error in an index shard test Cleanup Redundant BlobStoreFormat Class (elastic#42195) remove backcompat handling of 6.2.x versions (elastic#42044) Mute testDelayedOperationsBeforeAndAfterRelocated Execute actions under permit in primary mode only (elastic#42241) Mute another transforms_stats yaml test Deprecate support for chained multi-fields. (elastic#41926) Mute transforms_stats yaml test Make unwrapCorrupt Check Suppressed Ex. (elastic#41889) Remove Dead Code from Azure Repo Plugin (elastic#42178) Reorganize Painless doc structure (elastic#42303) Avoid unnecessary persistence of retention leases (elastic#42299) [ML][TEST] Fix limits in AutodetectMemoryLimitIT (elastic#42279) [ML Data Frame] Persist and restore checkpoint and position (elastic#41942) mute failing filerealm hash caching tests (elastic#42304) Safer Wait for Snapshot Success in ClusterPrivilegeTests (elastic#40943) Remove 7.0.2 (elastic#42282) Revert "Remove 7.0.2 (elastic#42282)" [DOCS] Copied note on slicing support to Slicing section. Closes 26114 (elastic#40426) Remove 7.0.2 (elastic#42282) ...
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
* No need to have an abstract class here when there's only a single impl.
original-brownbear
added a commit
that referenced
this pull request
May 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.