[ML-DataFrame] Combine task_state and indexer_state in _stats#45276
Merged
droberts195 merged 4 commits intoelastic:masterfrom Aug 7, 2019
Merged
Conversation
This commit replaces task_state and indexer_state in the data frame _stats output with a single top level state that combines the two. It is defined as: - failed if what's currently reported as task_state is failed - stopped if there is no persistent task - Otherwise what's currently reported as indexer_state Closes elastic#45201
Collaborator
|
Pinging @elastic/ml-core |
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Aug 7, 2019
Mutes data frame BWC tests prior to backporting elastic#45276
hendrikmuhs
approved these changes
Aug 7, 2019
| } else { | ||
|
|
||
| // Note: indexer state CAN be null if the task state is stopped or failed | ||
| assert(indexerState != null); |
There was a problem hiding this comment.
nit: the note and the assert look contradicting to me, indexerState should not be null, if there is no indexer it should be STOPPED
Author
There was a problem hiding this comment.
I don't think they were contradicting, as the "if the task state is stopped or failed" bit refers to the other code branches.
But since the way it was phrased was confusing I changed it in 3f35a2b to only refer to what's expected at the comment location.
droberts195
added a commit
that referenced
this pull request
Aug 7, 2019
Mutes data frame BWC tests prior to backporting #45276
This was referenced Aug 8, 2019
5 tasks
droberts195
added a commit
that referenced
this pull request
Aug 8, 2019
This commit replaces task_state and indexer_state in the data frame _stats output with a single top level state that combines the two. It is defined as: - failed if what's currently reported as task_state is failed - stopped if there is no persistent task - Otherwise what's currently reported as indexer_state Backport of #45276
droberts195
added a commit
that referenced
this pull request
Aug 8, 2019
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Aug 9, 2019
* Reflects the changes to transform stats on the ES side in elastic/elasticsearch#45276 * Updated mock __mocks__/data_frame_transform_list_row.json to reflect the new stats structure * Previously there were stats attributes task_state and indexer_state, now there is only state. * Renamed DATA_FRAME_TASK_STATE to DATA_FRAME_TRANSFORM_STATE . * Extended possible states to aborting, failed, indexing, started, stopped, stopping. * A stopped batch transform's stats no longer returns the progress until it was stopped. Instead of falling back and showing 0% with an empty progress bar, nothing will be shown. If the job is continued and returns progress again, the progress bar will also be shown again. * The expanded row's details tab now exposes hard-coded stats/state attributes instead of inferring attributes dynamically from objects. This was done so we can do custom formatting for date fields for example.
walterra
added a commit
to elastic/kibana
that referenced
this pull request
Aug 9, 2019
* Reflects the changes to transform stats on the ES side in elastic/elasticsearch#45276 * Updated mock __mocks__/data_frame_transform_list_row.json to reflect the new stats structure * Previously there were stats attributes task_state and indexer_state, now there is only state. * Renamed DATA_FRAME_TASK_STATE to DATA_FRAME_TRANSFORM_STATE . * Extended possible states to aborting, failed, indexing, started, stopped, stopping. * A stopped batch transform's stats no longer returns the progress until it was stopped. Instead of falling back and showing 0% with an empty progress bar, nothing will be shown. If the job is continued and returns progress again, the progress bar will also be shown again. * The expanded row's details tab now exposes hard-coded stats/state attributes instead of inferring attributes dynamically from objects. This was done so we can do custom formatting for date fields for example.
droberts195
added a commit
that referenced
this pull request
Sep 24, 2019
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Sep 24, 2019
The PRs that made these changes are: - elastic#44350 - elastic#45276 - elastic#45856 Co-Authored-By: István Zoltán Szabó <istvan.szabo@elastic.co> Co-Authored-By: Lisa Cawley <lcawley@elastic.co> Backport of elastic#46821
droberts195
added a commit
that referenced
this pull request
Sep 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit replaces
task_stateandindexer_statein thedata frame
_statsoutput with a single top levelstatethat combines the two. It is defined as:
failedif what's currently reported astask_stateisfailedstoppedif there is no persistent taskindexer_stateCloses #45201