Merged
Conversation
jrodewig
added
>docs
Collaborator
|
Pinging @elastic/es-search |
Collaborator
|
Pinging @elastic/es-docs |
62 tasks
jrodewig
force-pushed
the
intervals-query-reformat
branch
from
7cdb0f7 to
979319c
Compare
romseygeek
approved these changes
Aug 9, 2019
Contributor
romseygeek
left a comment
romseygeek
left a comment
There was a problem hiding this comment.
Thanks @jrodewig - a couple of small nits but LGTM overall
| { | ||
| "match" : { | ||
| "query" : "my favourite food", | ||
| "query" : "my favorite food", |
Contributor
There was a problem hiding this comment.
Two nations separated by the same language :)
| (Required, array of rule objects) Field you wish to search. | ||
|
|
||
| The value of this parameter is an array of rule objects used to match documents | ||
| based on matching terms, order, and proximity. |
Contributor
There was a problem hiding this comment.
It's a single rule object, rather than an array
| The `prefix` rule matches terms that start with a specified set of characters. | ||
| This prefix can expand to match at most 128 terms. If the prefix matches more than | ||
| 128 terms, {es} returns an error. You can use the | ||
| <<index-prefixes,`index-prefixes`>> option to avoid this limit. |
Contributor
There was a problem hiding this comment.
s/option to avoid/option on the field mapping to avoid/
| matches produced by the rules must all appear immediately next to each other. | ||
| + | ||
| -- | ||
| (Optional, integer) Maximum number of positions between the matching terms. |
Contributor
There was a problem hiding this comment.
s/terms/intervals produced by the rules/
Contributor
Author
|
Thanks for the review @romseygeek! |
jrodewig
added a commit
that referenced
this pull request
Aug 9, 2019
jrodewig
added a commit
that referenced
this pull request
Aug 9, 2019
jrodewig
added a commit
that referenced
this pull request
Aug 9, 2019
jrodewig
added a commit
that referenced
this pull request
Aug 9, 2019
jrodewig
added a commit
that referenced
this pull request
Aug 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the
intervalsquery to use the new query format.This creates separate sections for the example request, parameters, and notes. It also makes a few changes:
This is part of #40977, an effort to standardize documentation for query types.
Preview
http://elasticsearch_45350.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/query-dsl-intervals-query.html