Remove types from Get/MultiGet#46587
Merged
romseygeek merged 16 commits intoelastic:masterfrom Sep 20, 2019
Merged
Conversation
Collaborator
|
Pinging @elastic/es-search |
Contributor
|
@elasticmachine test this please |
1 similar comment
Contributor
Author
|
@elasticmachine test this please |
Contributor
Author
|
I've chased down a bunch of test failures here due to a change in MultiGetRequestBuilder that doesn't get caught by the compiler. The This could introduce some quite nasty and hard-to-track-down bugs into client code over an upgrade. I think the best solution is probably to rename the |
66 tasks
pgomulka
added a commit
that referenced
this pull request
Jun 9, 2021
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
Jun 9, 2021
retrofits typed get_source api removed in elastic#46931 and elastic#46587 relates elastic#51816
pgomulka
added a commit
that referenced
this pull request
Jun 14, 2021
80 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes types from the ShardGetService, and propagates this API change
up through the Transport and Rest actions for Get and MultiGet
Relates to #41059