[Transform]rename classes in transform plugin#46784
[Transform]rename classes in transform plugin#46784hendrikmuhs merged 8 commits intoelastic:masterfrom
Conversation
|
Pinging @elastic/ml-core |
hendrikmuhs
force-pushed
the
rename-to-transform-plug-classes
branch
from
9d203e3 to
eef09a1
Compare
droberts195
left a comment
droberts195
left a comment
There was a problem hiding this comment.
LGTM, but I realised it's not very hard to provide BWC for the "enabled" setting, so I left comments on how to do it. Let me know what you think.
| /** Setting for enabling or disabling data frame. Defaults to true. */ | ||
| public static final Setting<Boolean> DATA_FRAME_ENABLED = Setting.boolSetting("xpack.data_frame.enabled", true, | ||
| public static final Setting<Boolean> TRANSFORM_ENABLED = Setting.boolSetting("xpack.transform.enabled", true, | ||
| Setting.Property.NodeScope); |
There was a problem hiding this comment.
I know we said we wouldn't provide BWC for this, but it's actually trivial to do it and it might make someone's life easier:
// TODO remove before 8.0.0 release
private static final Setting<Boolean> DATA_FRAME_ENABLED = Setting.boolSetting("xpack.data_frame.enabled", true,
Setting.Property.NodeScope, Setting.Property.Deprecated);
public static final Setting<Boolean> TRANSFORM_ENABLED = Setting.boolSetting("xpack.transform.enabled", DATA_FRAME_ENABLED,
Setting.Property.NodeScope);
The Setting class completely takes care of the deprecation warnings.
So maybe we should?
We'll have other tweaks we need to make before 8.0.0 release, such as the role names, so it's not even like this creates much work for us.
| settings.add(PASSWORD_HASHING_ALGORITHM); | ||
| settings.add(INDEX_LIFECYCLE_ENABLED); | ||
| settings.add(SNAPSHOT_LIFECYCLE_ENABLED); | ||
| settings.add(DATA_FRAME_ENABLED); |
There was a problem hiding this comment.
If you agree it's not too hard to provide BWC for this then this line should stay with a TODO to remove it before 8.0.0 release.
4 participants
rename classes in transform plugin