Fix AutoFollowIT.testPauseAndResumeWithMultipleAutoFollowPatterns#48128
Merged
tlrx merged 4 commits intoelastic:masterfrom Oct 21, 2019
Merged
Fix AutoFollowIT.testPauseAndResumeWithMultipleAutoFollowPatterns#48128tlrx merged 4 commits intoelastic:masterfrom
tlrx merged 4 commits intoelastic:masterfrom
Conversation
tlrx
added
>test
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/CCR) |
Member
Author
|
@elasticmachine test this please |
1 similar comment
Member
Author
|
@elasticmachine test this please |
dnhatn
approved these changes
Oct 16, 2019
Member
dnhatn
left a comment
dnhatn
left a comment
There was a problem hiding this comment.
I left a smaller comment but LGTM. Thanks Tanguy.
| while (running.get()) { | ||
| while (running.get() && leaderIndices.get() < 20) { | ||
| final String prefix = randomFrom(prefixes); | ||
| final String leaderIndex = prefix + randomAlphaOfLength(10).toLowerCase(Locale.ROOT); |
Member
There was a problem hiding this comment.
I think we can have duplicate indices here.
Member
Author
There was a problem hiding this comment.
Right, thanks! I adapted the logic a bit to not create duplicate indices here.
Member
Author
|
@elasticmachine update branch (Lucene versions tests failed) |
Member
Author
|
Thanks @dnhatn ! |
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Oct 21, 2019
…astic#48128) The test testPauseAndResumeWithMultipleAutoFollowPatterns failed multiple times, mostly because it creates too many leader indices and the following cluster cannot cope with cluster state updates generated by following indices creation and pause/ resume auto-followers changes. This commit simplifies the test by creating at most 20 leader indices and by waiting for any new leader index to be picked up by the auto-follower before created another leader index. It also pause and resume less auto-followers as previously. closes elastic#47917
This was referenced Oct 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test
testPauseAndResumeWithMultipleAutoFollowPatternsfailed multiple times, mostly because it creates too many leader indices and the following cluster cannot cope with cluster state updates generated by following indices creation and pause/resume auto-followers changes.This PR simplifies the test by creating at most 20 leader indices and by waiting for any new leader index to be picked up by the auto-follower before created another leader index. It also pause and resume less auto-followers as previously.
closes #47917