fix incorrect comparison#48208
Merged
dakrone merged 2 commits intoelastic:masterfrom Oct 21, 2019
pedroprado010:patch-3
Merged
Conversation
the comparison `tookInMillis == tookInMillis` is always true.
Member
|
@elasticmachine ok to test |
dakrone
requested changes
Oct 17, 2019
Member
dakrone
left a comment
dakrone
left a comment
There was a problem hiding this comment.
Hi @pedroprado010, thanks for finding this. I left a comment, this should actually be changed to fix incorrect comparison rather than removing it.
| && Objects.equals(id, other.id) | ||
| && docVersion == other.docVersion | ||
| && found == other.found | ||
| && tookInMillis == tookInMillis |
Member
There was a problem hiding this comment.
This shouldn't actually be removed, this should actually be:
&& tookInMillis == other.tookInMillis
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Java High Level REST Client) |
pedroprado010
changed the title
dakrone
approved these changes
Oct 17, 2019
Member
dakrone
left a comment
dakrone
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this!
This was referenced Oct 21, 2019
dakrone
pushed a commit
to dakrone/elasticsearch
that referenced
this pull request
Oct 21, 2019
* remove comparison of identical values the comparison `tookInMillis == tookInMillis` is always true. * add comparison between tookInMillis
dakrone
pushed a commit
to dakrone/elasticsearch
that referenced
this pull request
Oct 21, 2019
* remove comparison of identical values the comparison `tookInMillis == tookInMillis` is always true. * add comparison between tookInMillis
dakrone
added a commit
that referenced
this pull request
Oct 21, 2019
dakrone
added a commit
that referenced
this pull request
Oct 21, 2019
dakrone
added a commit
that referenced
this pull request
Oct 21, 2019
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Oct 22, 2019
* elastic/master: [Docs] Fix opType options in IndexRequest API example. (elastic#48290) Simplify Shard Snapshot Upload Code (elastic#48155) Mute ClassificationIT tests (elastic#48338) Reenable azure repository tests and remove some randomization in http servers (elastic#48283) Use an env var for the classpath of jar hell task (elastic#48240) Refactor FIPS BootstrapChecks to simple checks (elastic#47499) Add "format" to "range" queries resulted from optimizing a logical AND (elastic#48073) [DOCS][Transform] document limitation regarding rolling upgrade with 7.2, 7.3 (elastic#48118) Fail with a better error when if there are no ingest nodes (elastic#48272) Fix executing enrich policies stats (elastic#48132) Use MultiFileTransfer in CCR remote recovery (elastic#44514) Make BytesReference an interface (elastic#48171) Also validate source index at put enrich policy time. (elastic#48254) Add 'javadoc' task to lifecycle check tasks (elastic#48214) Remove option to enable direct buffer pooling (elastic#47956) [DOCS] Add 'Selecting gateway and seed nodes' section to CCS docs (elastic#48297) Add Enrich Origin (elastic#48098) fix incorrect comparison (elastic#48208)
This was referenced Feb 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the comparison
tookInMillis == tookInMillisis always true.