Don't build packages on non Linux#48246
Merged
alpar-t merged 3 commits intoelastic:masterfrom Oct 21, 2019
Merged
Conversation
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
mark-vieira
approved these changes
Oct 18, 2019
Contributor
mark-vieira
left a comment
mark-vieira
left a comment
There was a problem hiding this comment.
I think we should explicitly exclude Windows, rather than only include Linux. Otherwise, LGTM.
distribution/packages/build.gradle
Outdated
| Closure commonPackageConfig(String type, boolean oss, boolean jdk) { | ||
| return { | ||
| onlyIf { | ||
| OS.current().equals(OS.LINUX) |
Contributor
There was a problem hiding this comment.
What about Mac? Does OSX have the same issue? Perhaps we should just explicitly exclude Windows since as I understand it this would make it impossible to run DEB/RPM packaging tests locally via Vagrant on a Mac.
pugnascotia
approved these changes
Oct 21, 2019
Contributor
Author
|
@elasticmachine update branch |
alpar-t
added a commit
that referenced
this pull request
Oct 21, 2019
* Don't build packages on non Linux Closes #47007 * Explicitly exclude windows only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #47007