Skip to content

Deprecate the sparse_vector field type.#48315

Merged
jtibshirani merged 2 commits intoelastic:masterfrom
jtibshirani:deprecate-sparse-vector
Oct 23, 2019
Merged

Deprecate the sparse_vector field type.#48315
jtibshirani merged 2 commits intoelastic:masterfrom
jtibshirani:deprecate-sparse-vector

Conversation

@jtibshirani
Copy link
Copy Markdown
Contributor

We have not seen much adoption of this experimental field type, and don't see a
clear use case as it's currently designed. This PR deprecates the field type in
7.x. It will be removed from 8.0 in a follow-up PR.

We issue a deprecation warning both when parsing the sparse_vector mapping,
and when a sparse vector function is passed to a script.

@jtibshirani jtibshirani added :Search/Search Search-related issues that do not fall into other categories >deprecation v8.0.0 v7.6.0 labels Oct 21, 2019
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-search (:Search/Search)

Copy link
Copy Markdown
Contributor

@mayya-sharipova mayya-sharipova Oct 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we issue a deprecation logging only when parsing a sparse_vector mapping in public Mapper.Builder<?,?> parse(..) instead of issuing it every time when parsing a document with a sparse_vector?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sorry I asked you to review a bit too early :) I still need to fix this, plus some failing docs tests.

@jtibshirani jtibshirani force-pushed the deprecate-sparse-vector branch from efb6e84 to fa5408b Compare October 21, 2019 22:57
We have not seen much adoption of this experimental field type, and don't see a
clear use case as it's currently designed. This PR deprecates the field type in
7.x. It will be removed from 8.0 in a follow-up PR.
@jtibshirani jtibshirani force-pushed the deprecate-sparse-vector branch from fa5408b to 1372639 Compare October 21, 2019 23:51
@jtibshirani
Copy link
Copy Markdown
Contributor Author

@mayya-sharipova this is now ready for another look, apologies again for the false start!

@jtibshirani
Copy link
Copy Markdown
Contributor Author

@elasticmachine run elasticsearch-ci/packaging-sample-matrix

Copy link
Copy Markdown
Contributor

@mayya-sharipova mayya-sharipova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtibshirani Thanks Julie, this looks good to me, as long as we have decided to remove sparse vectors in 8.0

@jtibshirani
Copy link
Copy Markdown
Contributor Author

@elasticmachine run elasticsearch-ci/packaging-sample-matrix

1 similar comment
@jtibshirani
Copy link
Copy Markdown
Contributor Author

@elasticmachine run elasticsearch-ci/packaging-sample-matrix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants