Skip to content

Remove type metadata from ingest documents#50131

Merged
romseygeek merged 2 commits intoelastic:masterfrom
romseygeek:types-removal/ingest-document-type
Dec 13, 2019
Merged

Remove type metadata from ingest documents#50131
romseygeek merged 2 commits intoelastic:masterfrom
romseygeek:types-removal/ingest-document-type

Conversation

@romseygeek
Copy link
Copy Markdown
Contributor

Referring to the _type field in an Ingest document has been deprecated and effectively
a no-op since 7.x, and we can remove support for it entirely in 8.0

Relates to #41059

@romseygeek romseygeek added >breaking :Distributed/Ingest Node Execution or management of Ingest Pipelines >refactoring v8.0.0 labels Dec 12, 2019
@romseygeek romseygeek self-assigned this Dec 12, 2019
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Ingest)

Copy link
Copy Markdown
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romseygeek romseygeek merged commit cc21437 into elastic:master Dec 13, 2019
@romseygeek romseygeek deleted the types-removal/ingest-document-type branch December 13, 2019 10:31
@jpountz jpountz mentioned this pull request Jan 15, 2020
66 tasks
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
Referring to the _type field in an Ingest document has been deprecated and effectively
a no-op since 7.x, and we can remove support for it entirely in 8.0

Relates to elastic#41059
@pgomulka pgomulka mentioned this pull request Mar 25, 2020
66 tasks
probakowski added a commit that referenced this pull request Feb 19, 2021
After #66197 we've lost ability to use longs for version, if_seq_no and if_primary_term (only ints would work).
That slipped through because 1 test went missing after refactoring in #50131.
This change fixes that with new ConfigurationUtils.readOptionalStringOrLongProperty method and and brings back the test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants