Merged
Conversation
dnhatn
added
>deprecation
:Distributed/Distributed
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Distributed) |
jrodewig
reviewed
Jan 10, 2020
client/rest-high-level/src/main/java/org/elasticsearch/client/IndicesClient.java
Outdated
Show resolved
Hide resolved
jrodewig
reviewed
Jan 10, 2020
client/rest-high-level/src/main/java/org/elasticsearch/client/IndicesClient.java
Outdated
Show resolved
Hide resolved
jrodewig
reviewed
Jan 10, 2020
client/rest-high-level/src/main/java/org/elasticsearch/client/IndicesClient.java
Outdated
Show resolved
Hide resolved
jrodewig
reviewed
Jan 10, 2020
...level/src/test/java/org/elasticsearch/client/documentation/IndicesClientDocumentationIT.java
Outdated
Show resolved
Hide resolved
jrodewig
reviewed
Jan 10, 2020
...level/src/test/java/org/elasticsearch/client/documentation/IndicesClientDocumentationIT.java
Outdated
Show resolved
Hide resolved
jrodewig
reviewed
Jan 10, 2020
...level/src/test/java/org/elasticsearch/client/documentation/IndicesClientDocumentationIT.java
Outdated
Show resolved
Hide resolved
jrodewig
reviewed
Jan 10, 2020
...level/src/test/java/org/elasticsearch/client/documentation/IndicesClientDocumentationIT.java
Outdated
Show resolved
Hide resolved
jrodewig
reviewed
Jan 10, 2020
jrodewig
reviewed
Jan 10, 2020
jrodewig
reviewed
Jan 10, 2020
jrodewig
reviewed
Jan 10, 2020
jrodewig
reviewed
Jan 10, 2020
jrodewig
reviewed
Jan 10, 2020
jrodewig
reviewed
Jan 10, 2020
jrodewig
reviewed
Jan 10, 2020
rest-api-spec/src/main/resources/rest-api-spec/api/indices.flush_synced.json
Outdated
Show resolved
Hide resolved
jrodewig
reviewed
Jan 10, 2020
rest-api-spec/src/main/resources/rest-api-spec/test/indices.flush/10_basic.yml
Outdated
Show resolved
Hide resolved
jrodewig
reviewed
Jan 10, 2020
rest-api-spec/src/main/resources/rest-api-spec/test/indices.flush/10_basic.yml
Outdated
Show resolved
Hide resolved
jrodewig
reviewed
Jan 10, 2020
...r/src/main/java/org/elasticsearch/action/admin/indices/flush/TransportSyncedFlushAction.java
Outdated
Show resolved
Hide resolved
jrodewig
reviewed
Jan 10, 2020
...r/src/main/java/org/elasticsearch/action/admin/indices/flush/TransportSyncedFlushAction.java
Outdated
Show resolved
Hide resolved
jrodewig
reviewed
Jan 10, 2020
Contributor
jrodewig
left a comment
jrodewig
left a comment
There was a problem hiding this comment.
Hi @dnhatn!
Overall, I think the docs for this are in pretty good shape. I left several non-blocking nits throughout.
The only blocking change I requested is re: the deprecated::[] note in synced-flush.asciidoc. The current deprecation block isn't rendering properly. I'd also move it higher up on the page.
dnhatn
force-pushed
the
deprecate-synced-flush
branch
from
c5d3788 to
f6f453f
Compare
Member
Author
Member
Author
|
Thanks James and Yannick! |
dnhatn
added a commit
that referenced
this pull request
Jan 14, 2020
A normal flush has the same effect as a synced flush on Elasticsearch 7.6 or later. It's deprecated in 7.6 and will be removed in 8.0. Relates #50776
dnhatn
added a commit
that referenced
this pull request
Jan 14, 2020
A normal flush has the same effect as a synced flush on Elasticsearch 7.6 or later. It's deprecated in 7.6 and will be removed in 8.0. Relates #50776
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
A normal flush has the same effect as a synced flush on Elasticsearch 7.6 or later. It's deprecated in 7.6 and will be removed in 8.0. Relates elastic#50776
This was referenced Feb 3, 2020
russcam
added a commit
that referenced
this pull request
Feb 5, 2020
Relates: #50835 This commit updates the synced flush REST API to use the deprecated object to deprecate the whole API.
russcam
added a commit
to russcam/elasticsearch
that referenced
this pull request
May 25, 2020
Relates: elastic#50835 This commit updates the synced flush REST API spec to deprecate the whole API.
russcam
added a commit
that referenced
this pull request
Aug 6, 2020
Relates: #50835 This commit updates the synced flush REST API spec to deprecate the whole API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A normal flush has the same effect as a synced flush on Elasticsearch 7.6 or later. It's deprecated in 7.6 and will be removed in 8.0.
Relates #50776