Fix issues which keep the temporary compat test fixutre#53301
Merged
jakelandis merged 4 commits intoelastic:compat_rest_apifrom Mar 10, 2020
Merged
Fix issues which keep the temporary compat test fixutre#53301jakelandis merged 4 commits intoelastic:compat_rest_apifrom
jakelandis merged 4 commits intoelastic:compat_rest_apifrom
Conversation
jakelandis
changed the title
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@pgomulka feel free to merge this PR to the feature branch. |
jakelandis
commented
Mar 9, 2020
| compile project(':test:framework') | ||
| } | ||
|
|
||
| test.enabled = false |
Contributor
Author
There was a problem hiding this comment.
note - this line will likely conflict with this line #53228
Contributor
There was a problem hiding this comment.
I have only disabled it temporarily to see if this will try to continue the build
pgomulka
approved these changes
Mar 10, 2020
Contributor
pgomulka
left a comment
pgomulka
left a comment
There was a problem hiding this comment.
LGTM, we have 283 failures - which is expected
| compile project(':test:framework') | ||
| } | ||
|
|
||
| test.enabled = false |
Contributor
There was a problem hiding this comment.
I have only disabled it temporarily to see if this will try to continue the build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses a few issues which prevented the
temporary compat test fixture from running.
It is expected that the compat tests will fail with this PR.