Move network stats marking into InboundPipeline#54393
Merged
Tim-Brooks merged 7 commits intoelastic:masterfrom Mar 31, 2020
Merged
Move network stats marking into InboundPipeline#54393Tim-Brooks merged 7 commits intoelastic:masterfrom
Tim-Brooks merged 7 commits intoelastic:masterfrom
Conversation
Tim-Brooks
added
>non-issue
:Distributed/Network
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Network) |
Contributor
original-brownbear
left a comment
original-brownbear
left a comment
There was a problem hiding this comment.
Looks good, just one issue with the time supplier
server/src/main/java/org/elasticsearch/transport/InboundPipeline.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/transport/InboundPipeline.java
Outdated
Show resolved
Hide resolved
ywelsch
reviewed
Mar 30, 2020
| @@ -676,9 +682,6 @@ public void inboundMessage(TcpChannel channel, InboundMessage message) { | |||
| } | |||
|
|
|||
| public void inboundDecodeException(TcpChannel channel, Tuple<Header, Exception> tuple) { | |||
Contributor
There was a problem hiding this comment.
Can we remove this method now?
Contributor
Author
There was a problem hiding this comment.
There will be a follow up related to exception handling. Specifically CircuitBreaking will move inside the pipeline. But circuit breaking generates an exception that has to be handled by generating a message to send back.
Contributor
Author
|
I have updated this PR for @original-brownbear changes. And will address @ywelsch comments in a follow-up. |
Tim-Brooks
added a commit
to Tim-Brooks/elasticsearch
that referenced
this pull request
Apr 7, 2020
This is a follow-up to elastic#48263. It moves the inbound stats tracking inside of the InboundPipeline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #48263. It moves the inbound stats tracking
inside of the InboundPipeline.