Disallow changing 'enabled' on the root mapper.#54681
Merged
jtibshirani merged 2 commits intoelastic:7.xfrom Apr 2, 2020
Merged
Disallow changing 'enabled' on the root mapper.#54681jtibshirani merged 2 commits intoelastic:7.xfrom
jtibshirani merged 2 commits intoelastic:7.xfrom
Conversation
In elastic#33933 we disallowed changing the `enabled` parameter in object mappings. However, the fix didn't cover the root object mapper. This PR adjusts the change to also include the root mapper and clarifies the error message.
jtibshirani
added
>bug
:Search Foundations/Mapping
Collaborator
|
Pinging @elastic/es-search (:Search/Mapping) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #54463, opening to get full build.