Remove DEBUG-level logging from actions in docker#57389
Merged
rjernst merged 2 commits intoelastic:masterfrom Jun 2, 2020
Merged
Remove DEBUG-level logging from actions in docker#57389rjernst merged 2 commits intoelastic:masterfrom
rjernst merged 2 commits intoelastic:masterfrom
Conversation
In elastic#51459 DEBUG-level logging was removed from the default log4j configuration. However, our docker build has its own log4j configuration which was missed in that change. This commit removes the same from the docker log4j configuration. relates elastic#51459 relates elastic#51198
rjernst
added
>enhancement
:Delivery/Packaging
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Packaging) |
nik9000
approved these changes
May 30, 2020
Member
nik9000
left a comment
nik9000
left a comment
There was a problem hiding this comment.
LGTM. I think it is also in the docker/config/oss version of the file too.
DaveCTurner
approved these changes
May 30, 2020
Member
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
LGTM2, but echoing Nik's comment that distribution/docker/src/docker/config/oss/log4j2.properties wants the same treatment.
Member
Author
|
@elasticmachine run elasticsearch-ci/packaging-matrix-windows |
mark-vieira
added
Team:Delivery
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #51459 DEBUG-level logging was removed from the default log4j
configuration. However, our docker build has its own log4j configuration
which was missed in that change. This commit removes the same from the
docker log4j configuration.
relates #51459
relates #51198