Do not release safe commit with CancellableThreads#59182
Merged
dnhatn merged 5 commits intoelastic:masterfrom Jul 8, 2020
Merged
Do not release safe commit with CancellableThreads#59182dnhatn merged 5 commits intoelastic:masterfrom
dnhatn merged 5 commits intoelastic:masterfrom
Conversation
dnhatn
added
>non-issue
:Distributed/Recovery
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Recovery) |
original-brownbear
approved these changes
Jul 8, 2020
Contributor
original-brownbear
left a comment
original-brownbear
left a comment
There was a problem hiding this comment.
LGTM thanks Nhat :) could we add a reasonable TODO that asks to simplify things again once the Lucene situation is fixed maybe?
Member
Author
|
@original-brownbear Thanks for reviewing. I've added a comment explaining why we prefer releasing a safe commit using the generic thread pool (see ff0f8f8). |
Member
Author
|
testSendSnapshotSendsOps was fixed in 865b6b5. |
Member
Author
|
@elasticmachine update branch |
dnhatn
added a commit
that referenced
this pull request
Jul 8, 2020
We are leaking a FileChannel in #39585 if we release a safe commit with CancellableThreads. Although it is a bug in Lucene where we do not close a FileChannel if we failed to create a NIOFSIndexInput, I think it's safer if we release a safe commit using the generic thread pool instead. Closes #39585 Relates #45409
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are leaking a FileChannel in #39585 if we release a safe commit with CancellableThreads. Although it is a bug in Lucene where we do not close a FileChannel if we failed to create a NIOFSIndexInput, I think it's safer if we release a safe commit using the generic thread pool instead.
Closes #39585
Relates #45409