Conversation
TIP block was missing due to the lack of line break prior to the "TIP"
Collaborator
|
Pinging @elastic/es-docs (>docs) |
Contributor
|
@elasticmachine Retest this please |
debadair
approved these changes
Jul 13, 2020
Contributor
debadair
left a comment
debadair
left a comment
There was a problem hiding this comment.
LGTM. I think the build failure must have been a transient thing, re-running.
This should also be applied to the 7.x and master branches.
Contributor
Author
|
Thanks, @debadair , is there an easy way to push the same change to 7.x and master? or should those be done by going to each individual branch and make adjustment independently? |
Contributor
|
I usually cherry-pick & push to the other branches. I'll just go ahead and merge the fix and port it for you. |
debadair
pushed a commit
to debadair/elasticsearch
that referenced
this pull request
Jul 13, 2020
TIP block was missing due to the lack of line break prior to the "TIP"
debadair
pushed a commit
to debadair/elasticsearch
that referenced
this pull request
Jul 13, 2020
TIP block was missing due to the lack of line break prior to the "TIP"
debadair
added a commit
that referenced
this pull request
Jul 13, 2020
debadair
added a commit
that referenced
this pull request
Jul 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TIP block was missing due to the lack of line break prior to the "TIP" line