Remove remaining deprecated api usages#59231
Merged
breskeby merged 3 commits intoelastic:masterfrom Jul 14, 2020
Merged
Conversation
- fix deprecated non annotated input property in LazyPropertyList - fix deprecated usage of AbstractArchiveTask.version
breskeby
added
:Delivery/Build
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
mark-vieira
approved these changes
Jul 13, 2020
Contributor
mark-vieira
left a comment
mark-vieira
left a comment
There was a problem hiding this comment.
LGTM. I assume all the security stuff was duplicated from the core x-pack project so that's why we've remoted it?
breskeby
deleted the
remove-duplicate-test-resources-causing-deprecation-warnings
branch
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Jul 14, 2020
- Fix duplicate path deprecation by removing duplicate test resources - fix deprecated non annotated input property in LazyPropertyList - fix deprecated usage of AbstractArchiveTask.version - Resolve correct test resources
breskeby
added a commit
that referenced
this pull request
Jul 14, 2020
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Jul 14, 2020
- Fix duplicate path deprecation by removing duplicate test resources - fix deprecated non annotated input property in LazyPropertyList - fix deprecated usage of AbstractArchiveTask.version - Resolve correct test resources
breskeby
added a commit
that referenced
this pull request
Jul 14, 2020
mark-vieira
added
Team:Delivery
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files in
x-pack/plugin/security/src/test/resources/org/elasticsearch/xpack/security/transport/ssl/certs/simple/are duplicates of
x-pack/core/src/test/resources/org/elasticsearch/xpack/security/transport/ssl/certs/simple/and both are used to be copied when running processTestResources inx-pack/plugin/security. This PR removes these duplicates from the codebase.Related to #57920