Skip to content

Scripting: Per context stats in script in _nodes/stats#59266

Merged
stu-elastic merged 9 commits intoelastic:7.xfrom
stu-elastic:bwc-fix/50152-painless-limit-per-context__07__node-stats
Jul 9, 2020
Merged

Scripting: Per context stats in script in _nodes/stats#59266
stu-elastic merged 9 commits intoelastic:7.xfrom
stu-elastic:bwc-fix/50152-painless-limit-per-context__07__node-stats

Conversation

@stu-elastic
Copy link
Copy Markdown
Contributor

Pending: #59265

Updated _nodes/stats:

  • Update script in _node/stats to include stats per context:
      "script": {
        "compilations": 1,
        "cache_evictions": 0,
        "compilation_limit_triggered": 0,
        "contexts":[
          {
            "context": "aggregation_selector",
            "compilations": 0,
            "cache_evictions": 0,
            "compilation_limit_triggered": 0
          },

Refs: #50152
Backport: #59265

Updated `_nodes/stats`:
 * Update `script` in `_node/stats` to include stats per context:

```
      "script": {
        "compilations": 1,
        "cache_evictions": 0,
        "compilation_limit_triggered": 0,
        "contexts":[
          {
            "context": "aggregation_selector",
            "compilations": 0,
            "cache_evictions": 0,
            "compilation_limit_triggered": 0
          },

```

Refs: elastic#50152
Backport: elastic#59625
@stu-elastic stu-elastic added :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache backport v7.9.0 labels Jul 9, 2020
@stu-elastic stu-elastic requested a review from rjernst July 9, 2020 15:12
@stu-elastic stu-elastic marked this pull request as ready for review July 9, 2020 15:12
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Scripting)

@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Jul 9, 2020
@stu-elastic stu-elastic requested a review from jdconrad July 9, 2020 16:30
@stu-elastic
Copy link
Copy Markdown
Contributor Author

This duplicates contexts in script and script_cache to make upgrade easier. While this makes the output much larger, it allows users to start using script before 8.x.

Copy link
Copy Markdown
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stu-elastic stu-elastic merged commit 94e213d into elastic:7.x Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache Team:Core/Infra Meta label for core/infra team v7.9.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants