Ensure fixture runtime dependencies are built before starting containers#59474
Merged
mark-vieira merged 1 commit intoelastic:masterfrom Jul 13, 2020
Merged
Conversation
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
mark-vieira
added a commit
that referenced
this pull request
Jul 13, 2020
mark-vieira
added a commit
that referenced
this pull request
Jul 13, 2020
mark-vieira
added
Team:Delivery
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a race condition in the build where runtime dependencies needed to start certain test fixtures may not exist before attempting to start the fixture Docker containers. This manifests as an odd error regarding missing service port information but the root cause is the containers actually failing to start from a
ClassNotFoundException. The issue is that an explicit dependency on the runtime classpath was missing, so there was no guarantee that the upstream Jars actually were built before attempting to start the fixture. We fix this by adding the runtime classpath configuration as an explicit task dependency.Closes #58795