Fix failure in AppendProcessorTests.testAppendingUniqueValueToScalar#62453
Merged
danhermann merged 2 commits intoelastic:masterfrom Sep 17, 2020
Merged
Fix failure in AppendProcessorTests.testAppendingUniqueValueToScalar#62453danhermann merged 2 commits intoelastic:masterfrom
danhermann merged 2 commits intoelastic:masterfrom
Conversation
danhermann
added
>test
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Ingest) |
elasticmachine
added
the
Team:Data Management (obsolete)
probakowski
approved these changes
Sep 17, 2020
Contributor
probakowski
left a comment
probakowski
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this! Just small suggestion from my side
|
|
||
| List<Object> valuesToAppend = new ArrayList<>(); | ||
| String newValue = randomAlphaOfLengthBetween(1, 10); | ||
| String newValue = originalValue + randomAlphaOfLengthBetween(1, 10); |
Contributor
There was a problem hiding this comment.
Maybe use randomValueOtherThan? It'll communicate intent better, I think
Contributor
Author
There was a problem hiding this comment.
Thanks, @probakowski! I didn't know about the randomValueOtherThan method.
danhermann
added a commit
to danhermann/elasticsearch
that referenced
this pull request
Oct 8, 2020
danhermann
added a commit
that referenced
this pull request
Oct 8, 2020
danhermann
added a commit
to danhermann/elasticsearch
that referenced
this pull request
Oct 23, 2020
danhermann
added a commit
that referenced
this pull request
Oct 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #62411