EQL: Replace ?"..." with """...""" for unescaped strings (#62539)#63174
Merged
matriv merged 1 commit intoelastic:7.xfrom Oct 2, 2020
Merged
EQL: Replace ?"..." with """...""" for unescaped strings (#62539)#63174matriv merged 1 commit intoelastic:7.xfrom
matriv merged 1 commit intoelastic:7.xfrom
Conversation
Use triple double quotes enclosing a string literal to interpret it as unescaped, in order to use `?` for marking query params and avoid user confusion. `?` also usually implies regex expressions. Any character inside the `"""` beginning-closing markings is considered raw and the only thing that is not permitted is the `"""` sequence itself. If a user wants to use that, needs to resort to the normal `"` string literal and use proper escaping. Relates to elastic#61659 (cherry picked from commit d87c2ca)
Collaborator
|
Pinging @elastic/es-ql (:Query Languages/EQL) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use triple double quotes enclosing a string literal to interpret it
as unescaped, in order to use
?for marking query params and avoiduser confusion.
?also usually implies regex expressions.Any character inside the
"""beginning-closing markings is consideredraw and the only thing that is not permitted is the
"""sequence itself.If a user wants to use that, needs to resort to the normal
"string literaland use proper escaping.
Relates to #61659
(cherry picked from commit d87c2ca)