Skip to content

Remove escape hatch permitting incompatible builds#65753

Merged
DaveCTurner merged 2 commits intoelastic:masterfrom
DaveCTurner:2020-12-02-remove-deprecated-sysprop
Dec 2, 2020
Merged

Remove escape hatch permitting incompatible builds#65753
DaveCTurner merged 2 commits intoelastic:masterfrom
DaveCTurner:2020-12-02-remove-deprecated-sysprop

Conversation

@DaveCTurner
Copy link
Copy Markdown
Member

@DaveCTurner DaveCTurner commented Dec 2, 2020

Today in 7.x there is a deprecated system property that bypasses the
check that prevents nodes of incompatible builds from communicating.
This commit removes the system property in master so that the check is
always enforced.

Relates #65601, #65249

@DaveCTurner
Remove escape hatch permitting incompatible builds
6c69799 
Today in `7.x` there is a deprecated system property that bypasses the
check that prevents nodes of incompatible builds from communicating.
This commit removes the system property in `master` so that the check is
always enforced.

Relates elastic#65601, elastic#65249
@DaveCTurner DaveCTurner added >breaking :Distributed/Network Http and internode communication implementations v8.0.0 labels Dec 2, 2020
@elasticmachine elasticmachine added the Team:Distributed Meta label for distributed team. label Dec 2, 2020
@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Dec 2, 2020

Pinging @elastic/es-distributed (Team:Distributed)

original-brownbear
original-brownbear approved these changes Dec 2, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@original-brownbear original-brownbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner
Copy link
Copy Markdown
Member Author

DaveCTurner commented Dec 2, 2020

@elasticmachine please run elasticsearch-ci/packaging-sample-windows (failure getting dependencies)

@DaveCTurner
Copy link
Copy Markdown
Member Author

DaveCTurner commented Dec 2, 2020

@elasticmachine please run elasticsearch-ci/packaging-sample-windows (failure getting dependencies again, but apparently it's ok now)

@DaveCTurner DaveCTurner merged commit ff5cb90 into elastic:master Dec 2, 2020
@DaveCTurner DaveCTurner deleted the 2020-12-02-remove-deprecated-sysprop branch December 2, 2020 19:30
@jakelandis jakelandis mentioned this pull request Feb 22, 2021
Closed
This was referenced Aug 9, 2021
Closed
Merged
masseyke added a commit that referenced this pull request Sep 3, 2021
@masseyke
Remove escape hatch permitting incompatible builds (#76513)
d7f992b 
The system property "es.unsafely_permit_handshake_from_incompatible_builds" was deprecated and has
been removed in 8.0. This adds a deprecation check for that property.
Relates to #42404 and #65753.
@jrodewig jrodewig mentioned this pull request Sep 14, 2021
Merged
jrodewig added a commit that referenced this pull request Sep 16, 2021
@jrodewig
[DOCS] Add deprecation docs for incompatible builds (#77730)
8402d6d 
We deprecated the `es.unsafely_permit_handshake_from_incompatible_builds` system
property in 7.11 with PR #65601. However, we didn't add a related item to the
7.11 deprecation docs. This adds the missing item.

Relates to #65753.
jrodewig added a commit that referenced this pull request Sep 16, 2021
@jrodewig
[DOCS] Add deprecation docs for incompatible builds (#77730) (#77960)
9332e5f 
We deprecated the `es.unsafely_permit_handshake_from_incompatible_builds` system
property in 7.11 with PR #65601. However, we didn't add a related item to the
7.11 deprecation docs. This adds the missing item.

Relates to #65753.
jrodewig added a commit that referenced this pull request Sep 16, 2021
@jrodewig
[DOCS] Add deprecation docs for incompatible builds (#77730) (#77961)
68fa321 
We deprecated the `es.unsafely_permit_handshake_from_incompatible_builds` system
property in 7.11 with PR #65601. However, we didn't add a related item to the
7.11 deprecation docs. This adds the missing item.

Relates to #65753.
jrodewig added a commit that referenced this pull request Sep 16, 2021
@jrodewig
[DOCS] Add deprecation docs for incompatible builds (#77730) (#77962)
b6af7e1 
We deprecated the `es.unsafely_permit_handshake_from_incompatible_builds` system
property in 7.11 with PR #65601. However, we didn't add a related item to the
7.11 deprecation docs. This adds the missing item.

Relates to #65753.
jrodewig added a commit that referenced this pull request Sep 16, 2021
@jrodewig
[DOCS] Add deprecation docs for incompatible builds (#77730) (#77963)
b77322a 
We deprecated the `es.unsafely_permit_handshake_from_incompatible_builds` system
property in 7.11 with PR #65601. However, we didn't add a related item to the
7.11 deprecation docs. This adds the missing item.

Relates to #65753.
jrodewig added a commit that referenced this pull request Sep 16, 2021
@jrodewig
[DOCS] Add deprecation docs for incompatible builds (#77730) (#77964)
68a28c9 
We deprecated the `es.unsafely_permit_handshake_from_incompatible_builds` system
property in 7.11 with PR #65601. However, we didn't add a related item to the
7.11 deprecation docs. This adds the missing item.

Relates to #65753.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@original-brownbear original-brownbear original-brownbear approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

>breaking :Distributed/Network Http and internode communication implementations Team:Distributed Meta label for distributed team. v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DaveCTurner @elasticmachine @original-brownbear @jakelandis